[Toaster] [review-request] toaster: review request for build dash board page

[Amit Kumar Chaudhary]

Edited subject line to have [review-request] in it, to make it filter friendly.

-- 
Amit Kumar Chaudhary

On 19 March 2014 at 5:13:13 pm, Amit Kumar Chaudhary (amit at floatingpondtech.com) wrote:

Hi Belen,

Fixed this one, combined the two calls into one, patch is available at achaudhary/combine_ready_calls

Thanks,

-- 
Amit Kumar Chaudhary

On 12 March 2014 at 11:50:22 pm, Barros Pena, Belen (belen.barros.pena at intel.com) wrote:

On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit at floatingpondtech.com>
wrote:

>
>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.

Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén



>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian at intel.com) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena at intel.com> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit at floatingpondtech.com>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140319/3a53b954/attachment-0001.html>