[Toaster] Review Request - add image information pages to toaster
Damian, Alexandru
alexandru.damian at intel.com
Thu Mar 20 04:52:01 PDT 2014
Hello Dave,
I am revisiting this patch. I missed this during this review -
- the filter tags in projecttags.py should not have any knowledge about the
model system in the application.
I'm specifically referring to this section.
+
+from django.db import models
+from orm.models import Package
+ at register.filter
+def runtime_dependencies(package_object, targetid):
+ """ Return a queryset that lists the packages this package depends on
+ """
+ return
package_object.package_dependencies_source.filter(target_id__exact=targetid,
dep_type__in={'1'})
+
+ at register.filter
+def reverse_runtime_dependencies(package_object, targetid):
+ """ Return a queryset that lists the packages depending on this package
+ """
+ return
package_object.package_dependencies_target.filter(target_id__exact =
targetid,dep_type__in={'1'})
I think it doesn't make sense reverting the whole patch, but this needs to
be fixed.
Can you please rework this section to compute relevant values in views.py
and pass them through the context, and submit the new patch to the list ?
Alex
On Mon, Mar 17, 2014 at 4:05 PM, Damian, Alexandru <
alexandru.damian at intel.com> wrote:
> Taken in, with changes - whitespace and typos.
>
> Alex
>
>
> On Fri, Mar 14, 2014 at 7:00 PM, Lerner, David M (Wind River) <
> dave.lerner at windriver.com> wrote:
>
>> >
>> > Dave, this is looking great. There is just two things:
>> >
>> > * the no results page is missing the tabs. So if I search and the search
>> > returns no results, the Packages included and Directory structure tabs
>> are
>> > no longer there, which is a bit puzzling. To see an example keeping the
>> > tabs, you can use this branch
>> >
>> >
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/fron
>> > t-end-050414
>> >
>> > And check the Configuration page.
>>
>> Fixed to match the above.
>>
>> >
>> > * from the installed package details page, clicking on a file brings me
>> to
>> > the all builds page. I have no idea why. If the file links to the
>> > directory structure are hard to get working, let's just take your work
>> > without it and open an issue in Bugzilla. It would be good to see this
>> > merged soon.
>>
>> Ah, the pending feature implementation from the other packages spec got
>> missed!
>>
>> I've updated the package included page to link to the directory structure
>> page, but not to the file. Fixing will take a bit of time, I agree that I
>> should fix this as an issue in Bugzilla and we should get my updated view
>> merged.
>>
>> When you are satisfied, can you ask Alex to merge lerner/imageinfo?
>> -dave
>>
>>
>> > Belén
>> >
>> > On 13/03/2014 21:49, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
>> >
>> > >Hi Belen, Alex
>> > >
>> > >Below is the review request for the image information pages for the
>> > >toaster project. Please advise if this is acceptable to be pulled into
>> > >master.
>> > >
>> > >There is a known problem with the help bubble and help icon hover on
>> > >expanded jtreetable rows.
>> > >
>> > >Thanks,
>> > >Dave Lerner
>> > >
>> > >=============================================
>> > >Summary: Add image information pages to toaster
>> > >Upstream branch Tag: poky-contrib lerner/imageinfo
>> > >
>> > >commit 6c644124111730e142222abb6d04979f69ca792e
>> > >Author: Dave Lerner <dave.lerner at windriver.com>
>> > >Date: Wed Mar 12 16:54:09 2014 -0500
>> > >
>> > > bitbake: toaster: image information views
>> > >
>> > > [YOCTO # 4346]
>> > >
>> > > When a target image is selected, this commit adds to the toaster
>> > > project a two-tabbed page that shows
>> > > 1) 'packages included' a table of packages included in the image
>> > > (see target.html), and
>> > > 2) 'directory structure', the target image's file system directory
>> > > and detailed information showing the source of each file in the
>> > > directory table (see dirinfo.html).
>> > >
>> > > The directory structure tab relies on the open source jQuery plugin
>> > > jtreetable which provides hierarchical table expansions and
>> > >contractions
>> > > of the directory entry tables as the user drills down into
>> > >directories.
>> > >
>> > > A file of jtreetable styles that are compatible with other toaster
>> > >styles
>> > > is provided included as css/jquery.treetable.theme.toaster.css. The
>> > > complete unaltered jtreetable plugin is added via a separate
>> commit.
>> > >
>> > > This work was developed base on the bugzilla specification number
>> 4346
>> > > and the document "Design 1.1 Image information" attached to that
>> > >report.
>> > >
>> > > Signed-off-by: Dave Lerner <dave.lerner at windriver.com>
>> > >
>> > > bitbake/lib/toaster/orm/models.py | 5 +-
>> > > .../lib/toaster/toastergui/static/css/default.css | 2 +-
>> > > .../static/css/jquery.treetable.theme.toaster.css | 38 ++++
>> > > .../static/jquery.treetable.theme.toaster.css | 66 ++++++
>> > > bitbake/lib/toaster/toastergui/templates/base.html | 2 +
>> > > .../toastergui/templates/basebuildpage.html | 2 +-
>> > > .../lib/toaster/toastergui/templates/dirinfo.html | 210
>> > >++++++++++++++++++
>> > > .../lib/toaster/toastergui/templates/target.html | 148
>> ++++++++++++-
>> > > .../toaster/toastergui/templatetags/projecttags.py | 50 +++++
>> > > bitbake/lib/toaster/toastergui/urls.py | 3 +-
>> > > bitbake/lib/toaster/toastergui/views.py | 223
>> > >+++++++++++++++++++-
>> > > 11 files changed, 732 insertions(+), 17 deletions(-)
>> > >
>> > >commit c05614ccea9f52a18cd7d162f98cf8cfae65591a
>> > >Author: Dave Lerner <dave.lerner at windriver.com>
>> > >Date: Tue Mar 4 15:02:58 2014 -0600
>> > >
>> > > bitbake: toaster: add jquery treetable plugin
>> > >
>> > > This commit includes the critical javascript and css files
>> > > downloaded from http://plugins.jquery.com/treetable version 3.1.0.
>> > > The following is from the author's README.md included with
>> > > the license files in the directory static/jquery-treetable-license.
>> > >
>> > > "jQuery treetable is a plugin for jQuery, the 'Write Less, Do More,
>> > > JavaScript Library'. With this plugin you can display a tree in an
>> > > HTML table, e.g. a directory structure or a nested list...
>> > > Download the latest release from the jQuery Plugin Registry or grab
>> > > the source code from Github. Please report issues through Github
>> > > issues. This plugin is released under both the MIT and the GPLv2
>> > > license by Ludo van den Boom...
>> > > See index.html for technical documentation and examples. The most
>> > > recent version of this document is also available online at
>> > > http://ludo.cubicphuse.nl/jquery-treetable. An AJAX enabled
>> example
>> > > built with Ruby on Rails can be found at
>> > > https://github.com/ludo/jquery-treetable-ajax-example."
>> > >
>> > > Author: Ludo van den Boom
>> > >
>> > > The relevant files were moved to the static/js and static/css
>> > > directories to match the existing javascript and css toaster
>> > > deployment model.
>> > >
>> > > The applicable licenses and the README are in
>> > > static/jquery-treetable-license.
>> > >
>> > > Signed-off-by: Dave Lerner <dave.lerner at windriver.com>
>> > >
>> > > .../toastergui/static/css/jquery.treetable.css | 28 +
>> > > .../static/css/jquery.treetable.theme.default.css | 64 ++
>> > > .../lib/toaster/toastergui/static/css/screen.css | 28 +
>> > > .../jquery-treetable-license/GPL-LICENSE.txt | 278 +++++++++
>> > > .../jquery-treetable-license/MIT-LICENSE.txt | 20 +
>> > > .../static/jquery-treetable-license/README.md | 20 +
>> > > .../toastergui/static/js/jquery.treetable.js | 620
>> > >++++++++++++++++++++
>> > > 7 files changed, 1058 insertions(+)
>> > >
>> > >
>> > >TESTING
>> > >
>> > >0. Test Setup
>> > >==================================
>> > >bitbake core-image-minimal
>> > >bitbake core-image-sato
>> > >
>> > >1. Tests on "Package included" tab
>> > >==================================
>> > >1.1 Package included HTML5 Validation
>> > >--------------------------------------
>> > >Select sato image and select all columns and 100 rows
>> > >Get source for page and input into
>> > >http://validator.w3.org/#validate_by_input
>> > >Verify no errors appear.
>> > >
>> > >Repeat for minimal image, all columns 100 rows (complete list)
>> > >Verify no errors appear.
>> > >
>> > >1.2 Package included Spec validation
>> > >------------------------------------
>> > >Package Included tab (page 5 of 17)
>> > >Tab data
>> > > Click on core-image-minimal
>> > > Note package count (1st term in 'n - m' in tab)
>> > > Change Show rows to 100, go the last page
>> > > Verify count by 100*pagenum + items on last page
>> > > Note package size (2nd term in 'n - m' in tab)
>> > > Sum the values in Size column on first and second page
>> > > Verify the calculated and shown total sums match within
>> roundoff
>> > >Default columns (page 7)
>> > > Clear cookies
>> > > Verify Package, Package Version, Size, Dependencies, Revers
>> > >Dependencies,
>> > > and Recipes columns appear
>> > > Verify package name and 'as installed <name>' in package column.
>> > > Additionally verify that search works on either package name
>> > > or installed name (eglibc or libc6)
>> > > Verify for 'as installed name' is muted, and shows help bubble and
>> > > clicking on help bubble brings up comment in spec
>> > > Verify that if you search for a non-existant package, then
>> > > "No packages found" appears
>> > > Verify if you search for a substring matching multiple packages,
>> then
>> > > "N packages found" appears, where N matches row count of a list
>> > > of matching packages
>> > > By clicking on Package name and jumping to package included detail
>> > >info
>> > > verify version, size, dependency count and list, reverse
>> > >dependency
>> > > count and list, and recipe (tested with busybox)
>> > > NOTE: bug to be entered that the Package Included dependency
>> size
>> > > shows Package Size (prior to build) not the post-build
>> > >installed
>> > > package size.
>> > > Verify the contents of the remaining table columns by selecting
>> those
>> > > columns in the Edit Columns tab: layer, layer branch layer
>> commit,
>> > > layer directory, license, recipe version and size over total %
>> > > Verify the order of the columns per spec page 9
>> > > Verify the minimum columns are package and package version
>> > > Verify Interactivity per page 11 on Package, Package Version,
>> > >dependencies,
>> > > reverse dependencies, recipe, recipe version, (layer url is not
>> > > yet implemented), and commit
>> > > Verify empty states on page 11
>> > >
>> > >
>> > >2. Tests on "Directory structure" tab
>> > >==================================
>> > >2.1 Directory structure HTML5 Validation
>> > >--------------------------------------
>> > >Select sato image, Directory structure, expand usr then lib under usr
>> > >View source for page and input it into
>> > > http://validator.w3.org/#validate_by_input
>> > >Verify no errors appear.
>> > >
>> > >2.2 "Directory structure" Spec validation
>> > >------------------------------------
>> > >Verify that page opens at top level directories (page 14)
>> > >Verify the fields directory/file, symbolic link, source package, size,
>> > > permissions, owner, and group are shown as specified on page 15
>> > >Verify that interacitivy of Directory/file and Source package as
>> > > specified on page 16. Note that slide animation has not been
>> > > implemented due to conflicts with the jtreetable plugin and other
>> > > issues with slide expansion in tables.
>> > >Verify that interacitivy of Source package with links to included
>> > > package page.
>> > >Note: not all directory entries will be associated with packages.
>> > >
>> > >End of tests
>> > >
>> > >
>> >
>>
>>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140320/f3c78f40/attachment-0001.html>
More information about the toaster
mailing list