[Toaster] [PATCH] toaster: full path in variable history

[Damian, Alexandru]

Taken in.

Alex


On Thu, Mar 20, 2014 at 9:04 AM, Marius Avram <marius.avram at intel.com>wrote:

>  I've made a build for core-image-minimal on top of commit
> master:3c70ad664685716d8d805aebf211daff4a062d1a with my patch applied
> inside a new build directory and I can confirm that the building process
> finished successfully.
>
>
> On 03/18/2014 05:40 PM, Damian, Alexandru wrote:
>
>  Please validate that the reading of the config files is not affected by
> deleting the recipe cache and trying to build from scratch.
>  This change cascades into the ast parser, not just logging and variable
> history.
>
>  Alex
>
>
> On Tue, Mar 18, 2014 at 3:15 PM, Avram, Marius <marius.avram at intel.com>wrote:
>
>> I only tested if the file_name fields from VariableHistory model is
>> filled correctly by accessing:
>> http://localhost:8000/api/1.0/variablehistory  which returns a JSON of
>> the table.
>>
>> I thought that replacing a relative path with an absolute path will not
>> have any impact on the build system, especially that this part is used for
>> variable history and logging.
>>
>> Would you want to make this change specific only to toaster ?
>>
>> From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
>> Sent: Tuesday, March 18, 2014 4:45 PM
>> To: Avram, Marius
>> Cc: toaster at yoctoproject.org
>> Subject: Re: [Toaster] [PATCH] toaster: full path in variable history
>>
>> This patch is not in a toaster-only file, I think it affects other parts
>> of Bitbake code.
>>
>> Can you please elaborate on the test plan you used to validate this
>> change ?
>>
>> Thank you,
>> Alex
>>
>>  On Tue, Mar 18, 2014 at 12:32 PM, Marius Avram <marius.avram at intel.com
>> <mailto:marius.avram at intel.com>> wrote:
>> When an evaluation was made for a configuration file the path to the
>> file was saved as a relative one. The change in this commit will save the
>> location as an absolute path. This way the user will have full information
>> regarding the location of the file where a variable was changed and the
>> line withing the file.
>>
>> [YOCTO #5562]
>>
>>  Signed-off-by: Marius Avram <marius.avram at intel.com<mailto:
>> marius.avram at intel.com>>
>> ---
>>  bitbake/lib/bb/parse/parse_py/ConfHandler.py |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bitbake/lib/bb/parse/parse_py/ConfHandler.py
>> b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
>> index f4fb2aa..978ebe4 100644
>> --- a/bitbake/lib/bb/parse/parse_py/ConfHandler.py
>> +++ b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
>> @@ -144,7 +144,7 @@ def handle(fn, data, include):
>>          # skip comments
>>          if s[0] == '#':
>>              continue
>> -        feeder(lineno, s, fn, statements)
>> +        feeder(lineno, s, abs_fn, statements)
>>
>>      # DONE WITH PARSING... time to evaluate
>>      data.setVar('FILE', abs_fn)
>> --
>> 1.7.9.5
>>
>> --
>> _______________________________________________
>> toaster mailing list
>>  toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>>  https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>
>
>
>  --
> Alex Damian
> Yocto Project
>  SSG / OTC
>
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140320/230baacd/attachment-0001.html>