[Toaster] dashboard update

Fri Mar 21 05:49:48 PDT 2014

Hi Alex,

> I've tried to rebase this on top of … but it does not apply cleanly.

I am not surprised, given all the changes since this push plus all of Amit’s pushes in parallel.

I have rebased my branch:  dreyna/build-dashboard

> "isDashboardPage" seems to be targeting only the dashboard page…

I have removed that from this submission. I will implement it together with 5916 once you and Belen come to an agreement.

> the filter system is intended…

I have moved the helper routine out of the filters and into the model.

I hope that this now meets your requirements.

- David

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Thursday, March 20, 2014 4:23 AM
To: Reyna, David
Cc: BARROS PENA, BELEN; toaster at yoctoproject.org; Wymore, Farrell
Subject: Re: [Toaster] dashboard update

Hi David, Farrell,

I've tried to rebase this on top of
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/submission-17032014

but it does not apply cleanly. Going a bit deeper into the review, I would suggest some changes:

- "isDashboardPage" seems to be targeting only the dashboard page; I'm not sure that cluttering base template files with page-specific code is a good idea, as it will lead to lots of very complicated code moving forward. I would suggest dropping this enhancement since it only affects whenever a link is enabled or not, the easy thing to do is just display the link at all times. If this is unacceptable, it is better to break the needed content into a block, and override this block in the dashboard-specific page.

- the filter system is intended to provide general text-manipulation, and not a way to manipulate objects.
The filters should have no knowledge of the object system or do database queries.
I suggest to provide needed needed values directly in the context and do all object-related manipulation in the view function;

Can you please re-work this patch ?

Thanks,
Alex

On Sun, Mar 16, 2014 at 12:04 AM, Reyna, David L (Wind River) <david.reyna at windriver.com<mailto:david.reyna at windriver.com>> wrote:
Hi Alex,

While Farrell is away, I have rebased and re-tested his commit as per your request, plus double-checked the diff between his branch to my replacement one.

The new branch can be found here: dreyna/build-dashboard

My branch is based on e665de5500ab1b44fd59dab897c736c62f487ff2 “bitbake: bitbake: cooker: some IMAGE_FEATURES not recognized”, which includes Amit’s commit d3d3a2c6ba71767e49a5b62fe74bf3b47688b911 “bitbake: toaster: add errors and warnings listing”.

Thanks,
David

From: toaster-bounces at yoctoproject.org<mailto:toaster-bounces at yoctoproject.org> [mailto:toaster-bounces at yoctoproject.org<mailto:toaster-bounces at yoctoproject.org>] On Behalf Of Damian, Alexandru
Sent: Friday, March 14, 2014 10:40 AM

To: Wymore, Farrell
Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
Subject: Re: [Toaster] dashboard update

Cannot rebase on top of latest submission tree, please wait until the 1403 submission is merged and rebase on top on origin/master.

Thanks,
Alex

On Wed, Mar 12, 2014 at 9:34 PM, Wymore, Farrell <Farrell.Wymore at windriver.com<mailto:Farrell.Wymore at windriver.com>> wrote:
Hi Belen,

You were right. There were a couple of areas where the targets were not getting sorted properly. I think these are now corrected.

    - fw

-----Original Message-----
From: Wymore, Farrell
Sent: Wednesday, March 12, 2014 12:22 PM
To: BARROS PENA, BELEN
Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
Subject: RE: dashboard update

Hi Belen,

I have amended the fwymore/build-dashboard branch adding the 'Tasks failed' and the adjusted in the link of the license manifest. I believe the sort order of the target names should be taken care of. Please let me know if this is not the case.

Please review. Thanks in advance - fw

-----Original Message-----
From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>]
Sent: Wednesday, March 12, 2014 8:58 AM
To: Wymore, Farrell
Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
Subject: Re: dashboard update
Hi Farrell,

Thanks for this. The vast majority of the stuff is done. The only things left on my list are:

* If a build has multiple targets, the breadcrumb should only show the first one (in alphabetical order). For example, I have a build that has 2
targets: core-image-base and core-image-minimal. The breadcrumb for this build should say: "core-image-base (+1)" but it says "core-image-minimal (+1)"

* The same with the left navigation, in the Images section targets should be listed in ascending alphabetical order. For the same build as above, I have again core-image-minimal displaying above core-image-base. It should be the other way around.

* The same with the order in the h1

* The label "License manifest² should be a link to the 'Packages included'
tab in the corresponding '1.1 Image information' page, showing the following columns: Package, Package version, License and Recipe (i.e. the information provided by the package manifest file).

* In the Tasks information we are missing the Failed tasks (if there are any).

I've gone ahead and fixed some other small things, which I've pushed here:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/i
magedashboard&id=8026dc5946abfd4603f704c1d4b2ce0a0b408493

Before making the changes listed above, could you please cherry pick this commit?

Thanks!!

Belén

On 11/03/2014 23:02, "Wymore, Farrell" <Farrell.Wymore at windriver.com<mailto:Farrell.Wymore at windriver.com>>
wrote:

>Hi Belen,
>
>I have made all the changes indicated in the dashboard page and I have
>rebased it.
>
>    fwymore/build-dashboard
>
>Please review, thanks - fw
>

--
_______________________________________________
toaster mailing list
toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster

--
Alex Damian
Yocto Project
SSG / OTC

--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140321/85343629/attachment-0001.html>