[Toaster] [toaster] [review-request] 5916 "The current page should have its left navigation item highlighted"

Reyna, David david.reyna at windriver.com
Mon Mar 24 20:02:32 PDT 2014


Hi Belen and Alex,

This patch implements the blocks for highlighting the navigation links per page, plus it makes the build's breadcrumb not be a link for the dashboard page, as per our discussions.

  * Here is the branch: dreyna/navbar_5916

It is after my "dreyna/build-dashboard" branch.

  * I have tested it for each navigation link, including both Configuration pages, and all four Tasks pages.

  * I have also tested it for multiple targets, but you either need to bring in Dave's target page, or you need to locally update the "poky/master" view class, in order to pass in the target  record for link matching purposes:

      def target(request, build_id, target_id):
          template = "target.html"
          if Build.objects.filter(pk=build_id).count() == 0 :
              return redirect(builds)
          context = {
                  'build' : Build.objects.filter(pk=build_id)[0],
                  'target': Target.objects.filter(pk=target_id)[0],
          }
          return render(request, template, context)

Thanks,
David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140325/1f37bcb3/attachment.html>


More information about the toaster mailing list