[Toaster] [review-request] V3: Bug #4865 "We need empty states for the different pages"

Tue Mar 25 18:57:03 PDT 2014

Hi Alex,

I have re-based to a new branch, and retested both the empty functionionality and also the “no search results” feature.

New branch: dreyna/empty_4865_v2

- David

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Tuesday, March 25, 2014 10:08 AM
To: BARROS PENA, BELEN
Cc: Reyna, David; toaster at yoctoproject.org
Subject: Re: [Toaster] [review-request] V3: Bug #4865 "We need empty states for the different pages"

Hello David,
Sorry to be a bother -

This patch doesn't apply anymore - it conflicts with a patch fixing the "no search results" issue.

Can you please rebase on top of the latest origin/master ?

Thank you,
Alex

On Fri, Mar 21, 2014 at 11:06 AM, Barros Pena, Belen <belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>> wrote:

On 21/03/2014 06:07, "Reyna, David" <david.reyna at windriver.com<mailto:david.reyna at windriver.com>> wrote:

>Hi Belen,
>
>Try again.

Working now. All ready to be merged from the UI side.

Thanks!

Belén

>Somehow my push did not work as expected, but I re-did it and I now see
>the change in poky/contrib:
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/em
>pty_4865&id=1e771e6108f06feda2f351fbf11c903d8144ceea
>
>    ...
>    + {% if mru.count == 0 %}
>>   + <div class="page-header top-air">
>>   + <h1>All builds</h1>
>>   + </div>
>    + <div class="alert alert-info lead">
>    + Toaster has not recorded any builds yet. Go build something with <a
>href="http://www.yoctoproject.org/docs/current/yocto-project-qs/yocto-proj
>ect-qs.html#test-run">Knotty</a> or <a
>href="https://www.yoctoproject.org/documentation/hob-manual">Hob</a>
>    + </div>
>    ...
>
>- David
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>]
>> Sent: Thursday, March 20, 2014 5:04 AM
>> To: Reyna, David
>> Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>> Subject: Re: [Toaster] [review-request] V3: Bug #4865 "We need empty
>>states
>> for the different pages"
>>
>>
>> On 19/03/2014 00:14, "Reyna, David" <david.reyna at windriver.com<mailto:david.reyna at windriver.com>> wrote:
>>
>> >Resent with Alex's preferred subject header key. - David
>> >
>> >> -----Original Message-----
>> >> From: toaster-bounces at yoctoproject.org<mailto:toaster-bounces at yoctoproject.org> [mailto:toaster-<mailto:toaster->
>> >> bounces at yoctoproject.org<mailto:bounces at yoctoproject.org>] On Behalf Of Reyna, David
>> >> Sent: Tuesday, March 18, 2014 3:50 PM
>> >> To: BARROS PENA, BELEN
>> >> Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>> >> Subject: [Toaster] V3: review request: Bug #4865 "We need empty
>>states
>> >>for
>> >> the different pages"
>> >>
>> >> > But now the <div class="page-header"> is gone when the database is
>> >>empty
>> >> > and there are no builds running, and it looks a bit odd :/
>> >>
>> >> Yes, I see it, and I have re-pushed with the fix.
>> >>
>> >>     dreyna/empty_4865
>>
>> I can't see the fix for this: the h1 "All builds" is still missing when
>> the database is empty and no builds are running.
>>
>> I am not sure what I am doing wrong. I am using this commit:
>>
>>
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/e
>>mp
>> ty_4865&id=b7799eb0dfaaea11a26878a2489e234712436225
>>
>> Cheers
>>
>> Belén
>>
>> >>
>> >> That should do it then, until we update the external links.
>> >> David
>> >>
>> >> > -----Original Message-----
>> >> > From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>]
>> >> > Sent: Tuesday, March 18, 2014 8:57 AM
>> >> > To: Reyna, David
>> >> > Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>> >> > Subject: Re: V2: review request: Bug #4865 "We need empty states
>>for
>> >>the
>> >> > different pages"
>> >> >
>> >> > Everything done!
>> >> >
>> >> >
>> >> > On 18/03/2014 13:23, "Reyna, David" <david.reyna at windriver.com<mailto:david.reyna at windriver.com>>
>>wrote:
>> >> >
>> >> > >Hi Belen,
>> >> > >
>> >> > >Thank you for your review. I have made and tested the changes:
>> >> > >    dreyna/empty_4865
>> >> > >
>> >> > >> I normally send a keyboard interrupt towards the end of the
>>recipe
>> >> > >>parsing
>> >> > >> process. That gets me a build with no tasks.
>> >> > >
>> >> > >You are more nimble fingered than I. I can now get the zero
>> >>packages, but
>> >> > >for the task list I keep getting at least the native-qemu task.
>> >> > >
>> >> > >> * In the Tasks, Time, CPU and Disk I/O pages 2 pipes are
>>appearing
>> >>above
>> >> > >> the h1 "||".
>> >> > >
>> >> > >Sorry, a left over debugging statement, now gone from this commit.
>> >> > >
>> >> > >I have been trying to find a way to get the "order" field to
>> >>re-appear by
>> >> > >default in the All Tasks page, but Toaster is confounding me.
>>Playing
>> >> > >with the hidden flag, the default sorting, the column position,
>> >>renaming
>> >> > >the "clclass", none of those work :-(
>> >> > >
>> >> > >- David
>> >> > >
>> >> > >> -----Original Message-----
>> >> > >> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>]
>> >> > >> Sent: Tuesday, March 18, 2014 5:09 AM
>> >> > >> To: Reyna, David
>> >> > >> Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>> >> > >> Subject: Re: review request: Bug #4865 "We need empty states for
>> >>the
>> >> > >> different pages"
>> >> > >>
>> >> > >>
>> >> > >>
>> >> > >> On 18/03/2014 03:11, "Reyna, David" <david.reyna at windriver.com<mailto:david.reyna at windriver.com>>
>> >>wrote:
>> >> > >>
>> >> > >> >I could not figure out a proper way to get an empty task list,
>>so
>> >>I
>> >> > >> >simulated it by commenting out the ³objects² value in the
>>context
>> >>for
>> >> > >>the
>> >> > >> >³tasks² view (as described below in my test plan).
>> >> > >>
>> >> > >> I normally send a keyboard interrupt towards the end of the
>>recipe
>> >> > >>parsing
>> >> > >> process. That gets me a build with no tasks.
>> >> > >>
>> >> > >> It's pretty much there. A couple of comments below:
>> >> > >>
>> >> > >> ALL BUILDS PAGE
>> >> > >>
>> >> > >> * We should set the href of the "Show me the manual" button to
>>the
>> >>right
>> >> > >> URL (https://www.yoctoproject.org/documentation/toaster- manual)
>> >>even if
>> >> > >> the page doesn't exist yet. That way is already done and it's
>> >>something
>> >> > >> less to think about when the release time pressure kicks :)
>> >> > >>
>> >> > >> * When the first build is running (no builds completed yet in
>>the
>> >> > >> database) the All builds section should not display
>> >> > >>
>> >> > >> * The spacing in the hero unit is a bit crammed. Can we add the
>> >> > >>following
>> >> > >> lines to default.css?
>> >> > >>
>> >> > >> .hero-unit { margin: 20px 0 30px; }
>> >> > >> .hero-unit > .close { font-size:40px; }
>> >> > >> .hero-actions { margin-top: 30px; }
>> >> > >>
>> >> > >> That will sort out the problem
>> >> > >>
>> >> > >> BUILT PACKAGES TABLE
>> >> > >>
>> >> > >> * Can we change "No Packages built" to "No packages built"?
>> >> > >>
>> >> > >> * Instead of "slight" the alert should say "slightly"
>> >> > >>
>> >> > >> GENERIC EMPTY STATE (tested with Tasks)
>> >> > >>
>> >> > >> * Time, CPU and Disk I/O pages are showing "Tasks" as h1
>> >> > >>
>> >> > >> * In the Tasks, Time, CPU and Disk I/O pages 2 pipes are
>>appearing
>> >>above
>> >> > >> the h1 "||".
>> >> > >>
>> >> > >>
>> >> > >>
>> >> > >
>> >> >
>> >>
>> >> --
>> >> _______________________________________________
>> >> toaster mailing list
>> >> toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
>> >> https://lists.yoctoproject.org/listinfo/toaster
>>
>

--
_______________________________________________
toaster mailing list
toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster

--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140326/fd0b9012/attachment-0001.html>