[Toaster] [review-request] 6004 "Set in file" and "Value" columns of "bitbake variables" page can't be sorted alphabetically.

Reyna, David david.reyna at windriver.com
Wed Mar 26 06:50:59 PDT 2014


Hi Belen,

This commit disables the sorting for the values and files columns in the configuration value page.

The commit is here: dreyna/configvar_sorts_6004

Here is the justification, as I noted in bugzilla:

vvvvvvvv
The reason for the apparent "out-of-place" values is that they have leading spaces, which put them into an unexpected separate section of the sort, especially since the leading spaces are for all intents and purposes invisible to the casual eye.

This, plus the fact that the sorting method is controlled by the database ("Django will order results however your database backend normally orders them") and in our case it is in literal ASCII order, means that while the sort is working as advertised, it will look odd and broken to the non-ASCII-aware user.

Since the value sort (a) will always look odd, (b) the search function does work, and (c) while interesting I cannot see much immediate value in the sorted values, I think we should disable it for 1.6 and look at implementing support for custom sorts in 1.7.
^^^^^^^^

- David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140326/1701b9de/attachment.html>


More information about the toaster mailing list