[Toaster] [toaster] [review-request] 5916 "The current page should have its left navigation item highlighted"
Damian, Alexandru
alexandru.damian at intel.com
Thu Mar 27 08:40:52 PDT 2014
Taken in.
Alex
On Tue, Mar 25, 2014 at 10:54 AM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:
>
>
> On 25/03/2014 03:02, "Reyna, David" <david.reyna at windriver.com> wrote:
>
> >Hi Belen and Alex,
> >
> >This patch implements the blocks for highlighting the navigation links
> >per page, plus it makes the build¹s breadcrumb not be a link for the
> >dashboard page, as per our discussions.
>
> >
> > * Here is the branch: dreyna/navbar_5916
>
> This is working great. Thanks!
>
>
> >
> >It is after my ³dreyna/build-dashboard² branch.
> >
> > * I have tested it for each navigation link, including both
> >Configuration pages, and all four Tasks pages.
> >
> >
> > * I have also tested it for multiple targets, but you either need to
> >bring in Dave¹s target page, or you need to locally update the
> >³poky/master² view class, in order to pass in the target record for link
> >matching purposes:
> >
> >def target(request, build_id, target_id):
> > template = "target.html"
> > if Build.objects.filter(pk=build_id).count() == 0 :
> > return redirect(builds)
> > context = {
> > 'build' : Build.objects.filter(pk=build_id)[0],
> > 'target': Target.objects.filter(pk=target_id)[0],
> > }
> > return render(request, template, context)
> >
> >Thanks,
> >David
> >
> >
>
>
--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140327/04587f10/attachment.html>
More information about the toaster
mailing list