[Toaster] [review requested] column sort order

[Barros Pena, Belen]

On 28/03/2014 18:09, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
wrote:

>This works for me. I have been fussing with this a bit more (mainly
>dealing with git problems) since I checked in the first change this
>morning. I have a couple of things I need to clean up. Let me do that.
>I'll let you know when to try again. Thanks.

Thanks! and sorry for all the back and forth.

>
>    - fw
>
>-----Original Message-----
>From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>Sent: Friday, March 28, 2014 11:01 AM
>To: Wymore, Farrell
>Cc: toaster at yoctoproject.org
>Subject: Re: [review requested] column sort order
>
>Hi Farrell,
>
>Thanks for this. With your changes, the following works correctly:
>
>* Sort the packages table by Size
>* Open the Edit columns menu
>* Deselect the Size column
>* Close the Edit columns menu
>
>When the menu closes, the Package sorting is applied. Nice! :)
>
>But if I try to do more than one thing in the Edit columns menu, the page
>refresh is triggered before I dismiss the menu. Try this:
>
>* Go to the Packages table
>* Sort it by Size
>* Open the Edit columns menu
>* Deselect the Size column
>* Select the Size column again
>* Then close the "Edit columns" menu
>
>The resorting is triggered before I dismiss the menu.
>
>So, I am starting to think this might be a bit too much work for an edge
>case. Would it be easier if we simply disable the checkbox for whichever
>column has the .sorted class applied? This means that when I sort by a
>certain column, if the checkbox for that column is not disabled by
>default, we disable it (add the disabled attribute to the input tag and
>the .muted class to the label tag). That might be an easy thing to do
>with jQuery.
>
>Let me know what you think.
>
>Thanks!!
>
>Belén
>
>
>
>On 28/03/2014 16:42, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
>wrote:
>
>>Hi Belen,
>>
>>I have amended this branch to have the indicated behavior - no action
>>taken until the pop-up is closed by the user - it passes the test below.
>>
>>     - fw
>>
>>-----Original Message-----
>>From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>>Sent: Friday, March 28, 2014 4:30 AM
>>To: Wymore, Farrell
>>Cc: toaster at yoctoproject.org
>>Subject: Re: [review requested] column sort order
>>
>>
>>
>>On 27/03/2014 20:33, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
>>wrote:
>>
>>>Hi Belen,
>>>
>>>Please review the correction for the column sort order issue #5919.
>>
>>Hi Farrell,
>>
>>This is behaving a bit funny. The sorting change should trigger only
>>when the user closes the "Edit columns" menu, and the "Edit columns"
>>menu should only close when the user closes it.
>>
>>I should be able to do something like:
>>
>>* Go to the Packages table
>>* Sort it by Size
>>* Open the Edit columns menu
>>* Deselect the Size column
>>* Select the Size column again
>>* Then close the "Edit columns" menu
>>
>>And the table should still be sorted by Size.
>>
>>Right now, when I deselect the column with the sorting applied, the
>>"Edit columns" menu closes by itself after a certain amount of time:
>>that should never happen. That menu should only ever be dismissed by
>>clicking the button or outside the menu area when the menu is open.
>>Dismissing it should trigger the sorting change when needed.
>>
>>Cheers
>>
>>Belén
>>
>>>I have applied this change to all displays that have tables with
>>>sortable/optional columns.
>>>
>>>
>>>Thanks in advance  - fw
>>>
>>>
>>
>>
>
>