[Toaster] [review-request][PATCH] bitbake: toastergui: fix show / hide columns in all builds table

[Smith, Elliot]

Looks good to me, submitted to bitbake-devel.

Elliot

On 21 August 2015 at 11:22, Belen Barros Pena <
belen.barros.pena at linux.intel.com> wrote:

> From: Belen Barros Pena <belen.barros.pena at intel.com>
>
> The classes errors_no and warnings_no were removed from the
> td tags in the builds.html template. That broke the show / hide
> columns functionality, which would hide only the table heading,
> but not the data cells.
>
> This patch brings back those classes so that you can hide
> and show the errors and warnings information.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena at intel.com>
> ---
>  bitbake/lib/toaster/toastergui/templates/builds.html | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html
> b/bitbake/lib/toaster/toastergui/templates/builds.html
> index b68fa6f..c0d0c64 100644
> --- a/bitbake/lib/toaster/toastergui/templates/builds.html
> +++ b/bitbake/lib/toaster/toastergui/templates/builds.html
> @@ -81,12 +81,12 @@
>                          <a href="{% url "tasks" build.id
> %}?filter=outcome%3A4">{{exectask.count}}
> task{{exectask.count|pluralize}}</a>
>                      {%endif%}
>              </td>
> -            <td class="errors.count">
> +            <td class="errors.count errors_no">
>                  {% if  build.errors.count %}
>                      <a class="errors.count error" href="{% url
> "builddashboard" build.id %}#errors">{{build.errors.count}}
> error{{build.errors.count|pluralize}}</a>
>                  {%endif%}
>              </td>
> -            <td class="warnings.count">{% if  build.warnings.count %}<a
> class="warnings.count warning" href="{% url "builddashboard" build.id
> %}#warnings">{{build.warnings.count}}
> warning{{build.warnings.count|pluralize}}</a>{%endif%}</td>
> +            <td class="warnings.count warnings_no">{% if
> build.warnings.count %}<a class="warnings.count warning" href="{% url
> "builddashboard" build.id %}#warnings">{{build.warnings.count}}
> warning{{build.warnings.count|pluralize}}</a>{%endif%}</td>
>              <td class="time"><a href="{% url "buildtime" build.id
> %}">{{build.timespent_seconds|sectohms}}</a></td>
>              <td class="output">
>                {% if build.outcome == build.SUCCEEDED %}
> --
> 2.3.2 (Apple Git-55)
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150828/fd92ea8b/attachment.html>