[Toaster] Review of "all machines" page

[Barros Pena, Belen]

Thanks, Michael.

A couple of comments in line, plus a couple of new things I've been able
to look at thanks to your fixes:

* the add layer notifications need to match the ones in all other pages.
Currently they say:

"You have added 2 layers: meta-handheld and its dependencies
meta-initramfs. Go to project configuration"

We should show the project name instead of the 'go to project
configuration' link, and the name of the layer added should be a link to
the layer details page. You can see how the notifications should look like
by adding a layer from the layer details page using the latest poky/master
branch

This is the commit that applied the changes

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=088c19d6442653c6b
39003057512d75b6c9508b7

* The 2-stage select machine process is not in place either. When I click
the 'select machine' button, I am brought to the project page, the machine
is changed, but I get no notification that the change has been made.



On 30/01/2015 19:49, "Michael Wood" <michael.g.wood at intel.com> wrote:

>Current work in progress available for testing at poky-contrib
>michaelw/all-machines
>
>(If there's no in-line comment it's an item that's still TODO).
>
>Michael
>
>>
>>
>> * The "Show rows" menu doesn't seem to be working properly. When you
>>load
>> the page, the table always shows 10 rows, independently of the value
>> selected in the "show rows" menu
>Fixed

Yes: it now shows 10 when you load the page, and there are 10 machines
listed per page. But the last selected value doesn't seem to be stored in
the cookie. If I select, for example, 50 rows, then visit a couple of
other pages, then I go back to the all machines page, the value is set
back to 10.

>>
>> * The machine file information is not coming in
>Unfortunately we have no information available on the machine file that
>I can find to display

We would need to check how the layer index gathers this information, and
do the same if we can. This sounds like a nice to have, and it might be,
but it is actually a 'very nice' to have. Basically, it is useful to be
able to quickly get to the source files if you need to understand what
they are doing. Can I ask you to have a chat with Paul to see how we can
provide this?