[Toaster] [review-request] michaelw/all-machines

[Damian, Alexandru]

Hello,

I've picked this up for submission with manual merges.

Thank you !

Alex

On Mon, Feb 9, 2015 at 2:00 PM, Michael Wood <michael.g.wood at intel.com>
wrote:

> One commit was missing and has now been added to the branch, if it's
> easier I can submit this a separate patch.
>
> commit ab531d30f7a1bef411d50491e5341671f97120ce
> Author: Michael Wood <michael.g.wood at intel.com>
> Date:   Mon Feb 9 13:54:14 2015 +0000
>
>     bitbake: toaster: All machines Fix filter counts
>
>     Filter counts needed to take into account the filters that had
>     previously been applied.
>
>     Signed-off-by: Michael Wood <michael.g.wood at intel.com>
>
>
> Thanks,
>
> Michael
>
>
> On 06/02/15 16:08, Barros Pena, Belen wrote:
>
>> On 06/02/2015 16:04, "Michael Wood" <michael.g.wood at intel.com> wrote:
>>
>>  poky-contrib michaelw/all-machines
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
>>> log/?h=michaelw/all
>>> -machines
>>>
>>> (for anyone else following, the issues below were due to a browser
>>> issue/data import)
>>>
>> Yep, that it's true. All UI issues are fixed now.
>>
>>  On 06/02/15 11:28, Barros Pena, Belen wrote:
>>>
>>>> On 05/02/2015 19:00, "Michael Wood" <michael.g.wood at intel.com> wrote:
>>>>
>>>>  Latest Update 3
>>>>> HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>>>>> poky-contrib michaelw/all-machines
>>>>>
>>>> The show rows menu seems to be acting up again :/ When you select a
>>>> value,
>>>> nothing happens
>>>>
>>>>  * Something funny going on with the layers: the openembedded-core
>>>>>> layer
>>>>>> appears as if it is not added to the project, but it is definitely
>>>>>> added
>>>>>> (it is added by default to all our projects). What's worse, when you
>>>>>> click
>>>>>> on 'add layer', you actually end up with 2 openembedded-core layers
>>>>>> added
>>>>>> to the project. When you hover over the second one, it seems to be
>>>>>> coming
>>>>>> from the oe repo, instead of the poky repo, and has not branch. I am
>>>>>> not
>>>>>> sure how up-to-date your branch is with master. If it is fully
>>>>>> up-to-date,
>>>>>> something has broken down with the layers :/
>>>>>>
>>>>> Fixed (update 3)
>>>>>
>>>> It's not working for me: the machines provided by layers added to the
>>>> project now don't show at all in the all machines page. You can check it
>>>> out using the filter in the 'select' column. It says that the number of
>>>> machines provided by layers added to the project is 0.
>>>>
>>>>  * Sorting by layer source reverts the sorting by machine, setting it
>>>>>>>> to z
>>>>>>>> to a. This should not happen: when I sort by layer source, machines
>>>>>>>> with
>>>>>>>> the same layer source should be sorted in alphabetical order (a to
>>>>>>>> z)
>>>>>>>>
>>>>>>> Fixed I think (update 3)
>>>>>
>>>> It's not working for me. When I sort by layer source, I still get the
>>>> zynq
>>>> machine at the top of the page (sorting by that column is also sorting
>>>> the
>>>> machines from z to a for some reason).
>>>>
>>>>  * The "select" column filter is not in place
>>>>>>>>
>>>>>>>>  Fixed (update 2)
>>>>>>
>>>>>>  * When applying a filter, the page heading does not update to show
>>>>>>>> the
>>>>>>>> number of results returned by the filter
>>>>>>>>
>>>>>>>>  Was this for filters or Search? I've implemented it for search but
>>>>>> I
>>>>>> didn't see in the designs the same thing happens for filters.
>>>>>> A: Both
>>>>>>
>>>>> Fixed (update 3)
>>>>>
>>>>>
>>>>> Things coming back to also for layerdetails
>>>>>    - Funny tooltip thing
>>>>>    - machine change confirm
>>>>>
>>>> Do you want me to open issues for this?
>>>>
>>>> Thanks!!
>>>>
>>>> Belén
>>>>
>>>>  Michael
>>>>>
>>>>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150209/c862c641/attachment.html>