[Toaster] [review-request] V3 - bitbake: toaster: Additional fixes for the project variable page (#7231)

[Damian, Alexandru]

The patch was taken, I replied to the other thread.

Cheers,
Alex

On Fri, Feb 13, 2015 at 12:47 AM, Reyna, David <david.reyna at windriver.com>
wrote:

>  Hi Belen,
>
> Ok, I have done my (hopefully) final pass.
>
> 1) I have factored the “html()” usage so that all the elements are
> injection-safe. For example, setting a variable’s value to
> “<strong>myval</strong>” is now rendered in text and not in HTML bold.
>
> 2) I have moved to “on('input',…)”. The bonus is that the validation for
> new variable names/values is immediate as per your request.
>
> 3) I have added your requested code that will additionally display an
> error message for lower case versions of blacklisted variables, in other
> words both “DL_DR” and “dl_dr” will trigger the blacklist error message
> when used as a custom variable name.
>
> 4) FYI, I did a code W3c Online Validation. While my code passes, there
> are two errors inherited from one of the parent HTML pages. I will follow
> up later since they appear to be passive errors.
>
>   * line 100 column 58 - Error: Element div not allowed as child of
> element ul in this context. (Suppressing further errors from this subtree.)
>
>  *<div class="alert" style="display:none">*
>
>   * line 109 column 109 - Error: Attribute disabled not allowed on element
> a at this point.
>
>   *<**a* *class**="btn btn-primary" **id**="build-button" **disabled**="disabled"
> **data-project-id**="1">Build</**a**>*
>
> - David
> _____________________________________________
> *From:* Reyna, David
> *Sent:* Thursday, February 12, 2015 4:04 AM
> *To:* belen.barros.pena at intel.com
> *Cc:* toaster at yoctoproject.org
> *Subject:* [review-request] bitbake: toaster: Additional fixes for the
> project variable page (#7231)
>
>
> Hi Belen,
>
> I want to do one final pass to replace all the “keyup” with
> “on('input',…)” and replace the “html()” statements that could allow data
> insertion (as per Michael), but I have all of the GUI elements in place and
> it is testable.
>
> List of fixes (in addition to the ones listed in the previous test commit):
>
>   * All “Delete” and “Edit” icons have tooltips dynamically added. In
> addition, the IMAGE_INSTALL_append now has the “Delete” icon visible on new
> pages when the value starts off not empty.
>
>   * The “DISTRO” value now has dynamic error checking for spaces and empty
> string.
>
>   * The IMAGE_FSTYPES now dynamically tests that at least one value is
> checked in order for the “Save” button to be enabled.
>
>   * The PACKAGE_CLASSES now has your desired fade-in when the selection is
> changed.
>
>   * When custom variables are deleted, they now fade away.
>
> - David
>
>
>
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150213/225b8114/attachment-0001.html>