[Toaster] [review-request] adamian/20150210-development
Barros Pena, Belen
belen.barros.pena at intel.com
Fri Feb 13 10:11:00 PST 2015
On 13/02/2015 13:15, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:
>Hello,
>
>Can you please review
>
>poky-contrib:adamian/20150210-development
>
>
>With fixes for the empty states for pages,
Checked this, but found a few issues. There they go:
* For the main starting page, I think we need some changes in the markup
and some css might be missing. I can take care of that
* For the main starting page, the image is the wrong image. You can find
the right image at
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-webhob-design/tree/WebHob_1
.5/assets/img/toaster_1.7.png
* the empty project builds page is not in place (it shows like a no
results page, which makes no sense since it includes a 'show all builds'
link)
* the empty all targets page is not place (it shows like a no results
page, which makes no sense since it includes a 'how all targets' link)
* the empty all machines page is not in place: you just see the lonely
table headings
* When you try to create a project in the case where there is no layer
information in the database, you get this error
Environment:
Request Method: POST
Request URL: http://127.0.0.1:8000/toastergui/newproject/
Django Version: 1.6
Python Version: 2.7.6
Installed Applications:
('django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.messages',
'django.contrib.sessions',
'django.contrib.admin',
'django.contrib.staticfiles',
'django.contrib.humanize',
'orm',
'toastermain',
'south',
'bldviewer',
'toastergui',
'bldcontrol')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware')
Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
in get_response
114. response = wrapped_callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in newproject
1996. prj = Project.objects.create_project(name =
request.POST['projectname'], release = Release.objects.get(pk =
request.POST['projectversion']))
File "/home/yocto/poky-contrib/bitbake/lib/toaster/orm/models.py" in
create_project
70. lv = Layer_Version.objects.filter(layer__name =
rdl.layer_name, up_branch__name =
release.branch_name)[0].get_equivalents_wpriority(prj)[0]
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py"
in __getitem__
132. return list(qs)[0]
Exception Type: IndexError at /toastergui/newproject/
Exception Value: list index out of range
* The empty configuration variables page is not working. If you go to the
admin interface and delete the variables we configure by default (distro,
image_fstypes, images_install_append, package_classes and sdkmachine) and
then you try to visit the configuration page, you get this error
Environment:
Request Method: GET
Request URL: http://127.0.0.1:8000/toastergui/project/1/configuration
Django Version: 1.6
Python Version: 2.7.6
Installed Applications:
('django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.messages',
'django.contrib.sessions',
'django.contrib.admin',
'django.contrib.staticfiles',
'django.contrib.humanize',
'orm',
'toastermain',
'south',
'bldviewer',
'toastergui',
'bldcontrol')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware')
Template error:
In template
/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/templates/projectco
nf.html,
error at line 436
Reverse for 'xhr_configvaredit' with arguments '('',)' and keyword
arguments '{}' not found. 1 pattern(s) tried:
['toastergui/xhr_configvaredit/(?P<pid>\\d+)/$']
426 :
427 : function onEditAjaxError(jqXHR, textstatus, error) {
428 : alert("XHR errored:\n" + error + "\n(" + textstatus +
")");
429 : // re-assert the event handlers
430 : }
431 :
432 : function postEditAjaxRequest(reqdata) {
433 : var ajax = $.ajax({
434 : type:"POST",
435 : data: $.param(reqdata),
436 : url:" {% url 'xhr_configvaredit' project.id%}
",
437 : headers: { 'X-CSRFToken':
$.cookie("csrftoken")},
438 : success: onEditAjaxSuccess,
439 : error: onEditAjaxError,
440 : })
441 : }
442 :
443 : function setDeleteTooltip(object) {
444 : object.tooltip({ container: 'body', html: true,
delay: {show: 400}, title: "Delete" });
445 : }
446 : function setChangeTooltip(object) {
Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
in get_response
114. response = wrapped_callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in projectconf
2889. return render(request, template, context)
File "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py"
in render
53. return HttpResponse(loader.render_to_string(*args, **kwargs),
File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py"
in render_to_string
169. return t.render(context_instance)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
140. return self._render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
_render
134. return self.nodelist.render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
840. bit = self.render_node(node, context)
File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py"
in render_node
78. return node.render(context)
File
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py"
in render
123. return compiled_parent._render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
_render
134. return self.nodelist.render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
840. bit = self.render_node(node, context)
File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py"
in render_node
78. return node.render(context)
File
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py"
in render
123. return compiled_parent._render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
_render
134. return self.nodelist.render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
840. bit = self.render_node(node, context)
File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py"
in render_node
78. return node.render(context)
File
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py"
in render
62. result = block.nodelist.render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
840. bit = self.render_node(node, context)
File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py"
in render_node
78. return node.render(context)
File
"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py"
in render
62. result = block.nodelist.render(context)
File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
render
840. bit = self.render_node(node, context)
File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py"
in render_node
78. return node.render(context)
File
"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py"
in render
447. six.reraise(*exc_info)
File
"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py"
in render
433. url = reverse(view_name, args=args, kwargs=kwargs,
current_app=context.current_app)
File "/usr/local/lib/python2.7/dist-packages/django/core/urlresolvers.py"
in reverse
509. return iri_to_uri(resolver._reverse_with_prefix(view,
prefix, *args, **kwargs))
File "/usr/local/lib/python2.7/dist-packages/django/core/urlresolvers.py"
in _reverse_with_prefix
429. (lookup_view_s, args, kwargs,
len(patterns), patterns))
Exception Type: NoReverseMatch at /toastergui/project/1/configuration
Exception Value: Reverse for 'xhr_configvaredit' with arguments
'('',)' and keyword arguments '{}' not found. 1 pattern(s) tried:
['toastergui/xhr_configvaredit/(?P<pid>\\d+)/$']
> and other bugs ?
>
>
>Cheers,
>Alex
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
More information about the toaster
mailing list