[Toaster] [review-request] bitbake: toaster: Additional fixes for the project variable page (#7231)

[Barros Pena, Belen]

Hi David,

All in this list works. I just have a couple of cosmetic comments:

* The 'not set' should have the muted class applied, so that it looks in
the nice, faded, grey colour
* When you add a custom variable, the icon-trash is a bit too close to the
variable name. If you add the following line to the default.css file

dt > .icon-trash { padding-left: 5px; }

It looks much better

And only more comment inline.

Thanks!!

Belén

On 12/02/2015 12:03, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belen,
> 
>I want to do one final pass to replace all the ³keyup² with
>³on('input',Š)² and replace the ³html()² statements that could allow data
>insertion (as per Michael), but I have all of the GUI elements in place
>and it is testable.
> 
>List of fixes (in addition to the ones listed in the previous test
>commit):
> 
>  * All ³Delete² and ³Edit² icons have tooltips dynamically added. In
>addition, the IMAGE_INSTALL_append now has the ³Delete² icon visible on
>new pages when the value starts off not empty.

> 
>  * The ³DISTRO² value now has dynamic error checking for spaces and
>empty string.

So the check for the empty string is not really needed. The 'save' button
is disabled whenever the text field is empty, which prevents people from
trying to save an empty value. This is a behaviour we have implemented all
across Toaster. I think we should keep the same approach here: rely on the
disables state of the 'save' button and remove the empty string message.

The check for spaces works wonderfully, but it needs a bit of space from
the text field. If you move the <span> with id distro-error-message
outside the <div> with class input-append the whole thing works out a bit
better visually.

> 
>  * The IMAGE_FSTYPES now dynamically tests that at least one value is
>checked in order for the ³Save² button to be enabled.
> 
>  * The PACKAGE_CLASSES now has your desired fade-in when the selection
>is changed.
> 
>  * When custom variables are deleted, they now fade away.
> 
>- David
> 
> 
>