[Toaster] [review-request] 6682 - Implement changes needed in the "All Projects" page

[Reyna, David]

Hi Belén,

Everything is almost done, but I have two issues.

1) You have requested two anchor jumps, "#project-details" and "#machine-distro" id to the project
Page.

However, these labels are implemented as "id" elements and not "name" elements, and as such cannot be used as regular anchors. Should I go ahead and edit the "project.html" page to additionally include these as "names"?

2) "The machine and target columns are not searchable"

This will not work for these synthetic values, for the same reason that the sort mechanism will not allow them.

	Request Method: 	GET
	Request URL: 	http://127.0.0.1:8000/toastergui/projects/?orderby=id%3A-&count=10&search=qemux86&page=1
	Django Version: 	1.6
	Exception Type: 	FieldError
	Exception Value: 	

	Cannot resolve keyword 'get_current_machine_name' into field. Choices are: bitbake_version, build, buildrequest, created, id, layer_version, name, projectlayer, projecttarget, projectvariable, release, short_description, updated, user_id

	Exception Location: 	/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py in names_to_path, line 1274

- David

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Wednesday, February 18, 2015 11:13 AM
> To: Reyna, David; DAMIAN, ALEXANDRU
> Cc: toaster at yoctoproject.org
> Subject: Re: [Toaster] [review-request] 6682 - Implement changes needed
> in the "All Projects" page
> 
> Hi David,
> 
> I've found some stuff with the projects table. Let me know if you have
> any
> questions:
> 
> * Something funky going on in the Edit columns menu. If you deselect
> last
> build, last errors, last image files, last outcome, last target and
> last
> warnings the table heading for last errors and last warnings are
> hidden,
> but not the data cells.
> 
> * The release name should link to the project details section in the
> project page. We need to link to the #project-details id in the project
> page
> 
> * The machine name should link to the project configuration section in
> the
> project page. We can probably use the #machine-distro id for this
> 
> *  The number of builds should be a link to the project builds page
> (except with the number of builds is 0)
> 
> * The last build date should be a link to the build dashboard page
> 
> * The default sorting for the last build column should be in inverse
> chronological order (most recent build on top). If a project has no
> builds, they should always show at the bottom, but this might not be
> possible (I am not sure)
> 
> * When you search and the search returns just one item, the heading
> should
> say "1 project found". Right now it says "1 projects found"
> 
> * The machine and target columns are not searchable (they should be)
> 
> * In the all builds table, the project column needs to move next to the
> machine column (see page 26 of the design document). It doesn't matter
> if
> the project column is not sortable, but it should be searchable. Also,
> the
> project filter should go away: the way it's implemented will break down
> the moment you have more than 5 or 6 projects
> 
> 
> 
> On 18/02/2015 17:29, "Reyna, David" <david.reyna at windriver.com> wrote:
> 
> >Ok, crisis averted, extra exception handling added. The commit should
> be
> >good now.
> >
> >  dreyna/all_projects_6682
> >
> >- David
> >
> >From: toaster-bounces at yoctoproject.org
> >[mailto:toaster-bounces at yoctoproject.org]
> >On Behalf Of Reyna, David
> >Sent: Wednesday, February 18, 2015 9:08 AM
> >To: BARROS PENA, BELEN; DAMIAN, ALEXANDRU
> >Cc: toaster at yoctoproject.org
> >Subject: Re: [Toaster] [review-request] 6682 - Implement changes
> needed
> >in the "All Projects" page
> >
> >
> >
> >Hi Belen,
> >
> >
> >
> >For my All Projects page, I found an issue when displaying projects
> that
> >have not been built yet (causes an error when looking up the FSTYPES
> to
> >pretty print
> > them). I am working on a fix, should have it within a few hours.
> >
> >
> >
> >- David
> >
> >
> >
> >_____________________________________________
> >From: Reyna, David
> >Sent: Wednesday, February 18, 2015 12:36 AM
> >To: belen.barros.pena at intel.com; Damian, Alexandru
> >(alexandru.damian at intel.com)
> >Cc: toaster at yoctoproject.org
> >Subject: [Toaster] [review-request] 6682 - Implement changes needed in
> >the "All Projects" page
> >
> >
> >
> >
> >
> >Hi Belen and Alex,
> >
> >
> >
> >1) I have implement all but the sorting (see below) changes for the
> ³All
> >Projects² page.
> >
> >
> >
> >    dreyna/all_projects_6682
> >
> >
> >
> >2) I could not get the sorting to work with the synthetic ³get_last_*²
> >values. It appears that these ³def² values are not accepted as
> sortable
> >columns. Unless Alex has some
> > magic I think we should skip this enhancement.
> >
> >
> >
> >* Here is the error:
> >
> >
> >  ³Invalid ordering model:<class
> >'orm.models.Project'>(u'get_last_target', ['bitbake_version', 'build',
> >'buildrequest', 'created', u'id', 'layer_version', 'name',
> 'projectlayer',
> > 'projecttarget', 'projectvariable', 'release', 'short_description',
> >'updated', 'user_id'])²
> >
> >
> >
> >* Here is the code snippet I had tested:
> >
> >
> >
> >Models.py:: Project()
> >
> >-   search_allowed_fields = ['name', 'short_description',
> >'release__name', 'release__branch_name']
> >
> >+   search_allowed_fields = ['name', 'short_description',
> >'release__name', 'release__branch_name', 'get_last_target']
> >
> >
> >
> >Views.py:: projects()
> >
> >                    {'name': 'Last target', 'clclass': 'ltarget',
> >
> >                    'qhelp': "The last project build target(s): one or
> >more recipes or image recipes",
> >
> >+                    'orderfield': _get_toggle_order(request,
> >"get_last_target"),
> >
> >+                    'ordericon':_get_toggle_order_icon(request,
> >"get_last_target"),
> >
> >+                    'orderkey' : 'get_last_target',
> >
> >                    },
> >
> >
> >
> >3) Here is what is working
> >
> >
> >
> >  [x] In the Edit columns menu, the "Last image files" checkbox only
> >shows /hide the table heading, and not the cells in the table body
> >
> >  [x] The 'last updated' column change the column heading  to "last
> >build' and move the column to right after the 'number of builds' one
> >
> >  [x] The release in the table should link to the 'Project details'
> >section of the corresponding project page
> >
> >  [x] The data for the following columns is not being displayed:
> Machine,
> >Number of builds, Last outcome, Last target, Last errors, Last
> warnings,
> >Last image files
> >
> >  [x] The heading should show the number of results returned when you
> >search
> >
> >  [x] The 'no results' page is not in place
> >
> >
> >
> >I also ported the fancy column entry formatting from the ³builds²
> page.
> >
> >
> >
> >- David
> >
> >
> >
> >
> >
> >
> >
>