[Toaster] [review-request][PATCH] bitbake: toaster: importlayer Remove description input field

[Barros Pena, Belen]

I know this was taken, but the revision label is missing the class
project-form, which sets the correct spacing :/ I've pushed a patch to

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/7
190&id=d6a7416c8e9efe4222fa54d8ff9d96076d56a00a

Any chance you can take it with Michael's patch?

Thanks!!

Belén

On 18/02/2015 19:00, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:

>Taken for submission,
>
>Thank you,
>Alex
>
>
>
>On Wed, Feb 18, 2015 at 3:18 PM, Michael Wood
><michael.g.wood at intel.com> wrote:
>
>This wasn't required or working due to a typo and adds ambiguity between
>the summary and description. The correct method for changing the
>description
>or summary is via the layerdetails page.
>
>[YOCTO #7190]
>
>Signed-off-by: Michael Wood <michael.g.wood at intel.com>
>---
> bitbake/lib/toaster/toastergui/static/js/importlayer.js   | 1 -
> bitbake/lib/toaster/toastergui/templates/importlayer.html | 6 ------
> bitbake/lib/toaster/toastergui/views.py                   | 3 ---
> 3 files changed, 10 deletions(-)
>
>diff --git a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>index e782bda..9d54286 100644
>--- a/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>+++ b/bitbake/lib/toaster/toastergui/static/js/importlayer.js
>@@ -136,7 +136,6 @@ function importLayerPageInit (ctx) {
>         name: layerNameInput.val(),
>         vcs_url: vcsURLInput.val(),
>         git_ref: gitRefInput.val(),
>-        summary:  $("#layer-summary").val(),
>         dir_path: $("#layer-subdir").val(),
>         project_id: ctx.projectId,
>         layer_deps: layerDepsCsv,
>diff --git a/bitbake/lib/toaster/toastergui/templates/importlayer.html
>b/bitbake/lib/toaster/toastergui/templates/importlayer.html
>index a4d8ee1..1196e0c 100644
>--- a/bitbake/lib/toaster/toastergui/templates/importlayer.html
>+++ b/bitbake/lib/toaster/toastergui/templates/importlayer.html
>@@ -84,12 +84,6 @@
>                             </div>
>                           </div>
>
>-                          <label class="project-form"
>for="layer-description">Layer description
>-                            <span class="muted">(optional)</span>
>-                            <span class="icon-question-sign get-help"
>title="A short layer explanation" />
>-                          </label>
>-                          <textarea id="layer-description"
>class="input-xxlarge"></textarea>
>-
>                     </fieldset>
>                     <fieldset class="air">
>                         <legend>
>diff --git a/bitbake/lib/toaster/toastergui/views.py
>b/bitbake/lib/toaster/toastergui/views.py
>index b5ff9b1..825cf80 100755
>--- a/bitbake/lib/toaster/toastergui/views.py
>+++ b/bitbake/lib/toaster/toastergui/views.py
>@@ -2413,9 +2413,6 @@ if toastermain.settings.MANAGED:
>             if layer_created:
>                 layer.layer_source = layer_source
>                 layer.vcs_url = post_data['vcs_url']
>-                if post_data.has_key('summary'):
>-                    layer.summary = layer.description =
>post_data['summary']
>-
>                 layer.up_date = timezone.now()
>                 layer.save()
>             else:
>--
>2.1.0
>
>--
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>