[Toaster] [review-request] (repeat) 6154 add sorting, searching, paging to recipe-package detail

[Barros Pena, Belen]

Hi Dave,

Thanks for this. A few comments below:

* The default size sorting should be in inverse order (i.e. the biggest
package on top), as it is in the main packages tables. Right now, when you
click to sort for the first time you get the packages with size 0B on top

* When the search returns no results, you get the same message you get
when the recipe does not build any packages. The no results page should
look like the one in page 6 of this document

https://bugzilla.yoctoproject.org/attachment.cgi?id=1810

* You are reusing the controls that we use for the main tables, but the
controls should be like the ones shown in this design document:

https://bugzilla.yoctoproject.org/attachment.cgi?id=1810

** There should be no 'edit columns' menu
** There should be no number of entries at the bottom of the table
** The pagination should be left aligned
** Search and show rows menus at the top of the table should not be inside
a navbar element

The controls have been implemented as designed in the layer details page,
so you can have a look at them there. To see that page, start Toaster in
build mode (making sure the database is populated with layer source
information), create a project with release master, click on the 'view all
compatible layers' link, select the meta-fsl-arm layer, go to the
'targets' tab.

Let me know if you have any questions.

Cheers

Belén



On 25/02/2015 21:24, "Lerner, Dave" <dave.lerner at windriver.com> wrote:

>(repeat of earlier email correcting subject tag spelling from
>[reveiew-request] to [review-request]
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=lerner/re
>cipe_package_sort_6154&id=3f1a0da20de69787bf855fc08bf4e749630cde12
>
>Implements fix and features for 6154, which adds column sorting,
>searching, pagination to the recipe packages page.
>
>A recipe with >1700 packages is glibc-locale to test searching,
>pagination and performance.
>
>lerner/recipe_package_sort_6154
>
>-Dave Lerner