[Toaster] [review-request] adamian/20150107-allbuilds-6671

[Damian, Alexandru]

On Mon, Jan 12, 2015 at 4:45 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

>
>
> On 12/01/2015 16:32, "Damian, Alexandru" <alexandru.damian at intel.com>
> wrote:
>
> >I guess we need to find reasonable values for ttruncation -
> >
> >
> >- Not all the error messages are displayed - just the first 3, but there
> >may be lots of errors not being displayed.
> >
> >
> >- In the table, the error messages are truncated after the first word
> >ending after 32 characters, because the errors can be quite long and will
> >mess up the table.
>
> We kind of have design for this. As a general rule, these builds behave
> like any other builds, i.e., they show the number of errors thrown and
> clicking the number brings you to the build dashboard page where the full
> error(s) text is shown.
>

​In fact, these are not builds like successful  b​uilds, in fact they don't
have a Build object.
They are build requests, and the information is faked to resemble a regular
build in the page.

This in fact prevents us from displaying a build dashboard page at all. I
would strongly suggest we do not show a build dashboard for failed build
requests, but show another kind of error detailed, possibly under "Project"
section.


> The only exception are 4 types of errors that hopefully are easy to
> identify and that we can help users recover from because we know what's
> causing the issue:
>
> 1. Layers that fail to clone
> 2. Nothing provides <target>
> 3. Invalid machine
> 4. Invalid distro
>

​I am not comfortable categorizing the exceptions we see at this point,
because there may be lots of things that can go wrong in the system.

In fact, we can only reliable detect the "Nothing provides" type of errors,
and not other errors, because the system underneath doesn't throw clear-cut
error messages except for the missing targets.

On any error, I would prefer a way to show full text of the error ​because
it may help the user understand what he should do, or at least copy-paste
full error report back to us.


> For these builds, we still show the number of errors link to the build
> dashboard page, but we also show some custom text to explain the problem
> in a bit more detail to users. Details in pages 44 to 56 of the design
> document 'Configuring projects' attached to 6587:
>
> https://bugzilla.yoctoproject.org/attachment.cgi?id=2230
>
>
​I think we need to revise this design​ because we can't reliably detect
types of errors, nor we can provide actionable items for users to do; I do
not think there is a great benefit for the users if we spend lot of time
categorizing the errors we detect, and translate tool output from English
to English.

What I mean, there are lot things that can go wrong beside the categorized
types of errors in the document; providing direct tool output to users may
enable them, for example, to Google common tool output (e.g. bitbake or git
error messages) instead hiding the messages behind a layer of text; or they
can copy/paste detailed error messages in an bug report.



>
> We might need a separate Bugzilla entry for this work.
>
> Cheers
>
> Belen
>
> >
> >
> >
> >
> >
> >
> >
> >On Mon, Jan 12, 2015 at 3:51 PM, Barros Pena, Belen
> ><belen.barros.pena at intel.com> wrote:
> >
> >Seems to be working for me: failed build requests now show in both project
> >page and all builds page. Although we'll need to change the way we are
> >displaying them (we don't want all the errors listed in the build item,
> >which is just a summary)
> >
> >Thanks!
> >
> >Belén
> >
> >On 12/01/2015 14:50, "Damian, Alexandru" <alexandru.damian at intel.com>
> >wrote:
> >
> >>Hello,
> >>
> >>
> >>Can you please review the implementation for showing failed and pending
> >>build requests in the "all builds" page, for bug 6671 ?
> >>
> >>
> >>The patch is pushed here:
> >>poky-contrib:adamian/20150107-allbuilds-6671
> >>
> >>
> >>
> >>
> >>
> >>​Cheers,
> >>Alex​
> >>
> >>
> >>--
> >>Alex Damian
> >>Yocto Project
> >>
> >>SSG / OTC
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >--
> >Alex Damian
> >Yocto Project
> >
> >SSG / OTC
> >
> >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150113/5df5168c/attachment.html>