[Toaster] [review-request] dreyna/project-config-vars-6588

[Reyna, David]

Hi Belen,

Here is my re-based and updated commit for the project configure page. I will list the remaining (non-blocking) issues that I would like to postpone till the next sprint, and I will also list the items I believe fixed now.

1) You have to start with a clean database to get the JSON file updates.

  $ cd .../poky/..
  $ rm -f toaster.sqlite
  $ ./poky/bitbake/bin/toaster
  ...
  -- Do you want to import basic layer configuration from "/opt/dreyna/yp-1.8/poky/meta-yocto/conf/toasterconf.json" ? (y/N):y
  ...
  $

2) Here are the remaining issues that I propose postponing till the next check-in

[?] ** When I add a variable, and then I click the "change" icon: ... 2) the "delete" icon disappears (it should stay next to the
variable name).

DLR: For #2, I believe that the "delete" icon _must_ disappear here, because I would think that one should not be able to delete the variable while one is in the state of changing its value.

[?] ** While a validation message is showing, the 'add variable' button should
be disabled: we don't want users to submit an invalid value.

DLR: I was unable to replicate this issue. Do you have a specific workflow that led to this observation?

[-] ** The validation message should be cleared the moment I remove the
offending character (.i.e. on keyup). Right now they are cleared on blur.

DLR: Postpone?

[-] ** this might be too much to ask, but I'll write it down any way. Variable
names are case sensitive, which I guess means that IMAGE_FSTYPES is not
the same as image_fstypes. However, since we are checking for the
blacklisted variables any way, is there any chance we could check for
their lower case variants as well so that they prompt the same validation
message the uppercase ones show?

DLR: Postpone?

[-] ** When I click the "delete" icon, the variable just disappears: we are
missing the fade out animation (the same one we are using for
IMAGE_INSTALL_append)

DLR: I almost have this fully working. There is just a remaining flash of the value after it slides up and before the page is redrawn.


3) Here are the issues that believe are now fixed

* 'add variable' form

[x] ** When you input something in the "variable" field, the div containing
the form controls (id="add-configvar-name-div") loses the span3 class,
which moves the help text about the blacklisted variables below the form.

[x] ** With the addition of the help text about the blacklisted variables, we
need to display the validation error messages below the input fields. To
do this, we just need to change the class of
id="new-variable-error-message" from .help-inline to .help-block

[x] ** I can see the extra spacing being added when you apply the classes
.control-group and .error to show the validation messages. This is caused
by applying the classes to the div id="add-configvar-name-div". This
approach has another small problem: it applies the error styles to both
input fields, not only to the one causing the validation message. I have a
small workaround for this: let me know what you think. Instead of applying
the classes to id="add-configvar-name-div", we could wrap the offending
input field, label and error message on a span tag, and apply the classes
to that span. Like so:

This will make the form look like the attached screenshot. Do you think
this is possible?

 [x] ** For the variable field, all validation messages are working correctly,
except the one caused by the presence of a space. When I type a space, I
get this message: "A valid variable name can only include letters,
numbers, underscores, dashes and cannot include spaces". But I should get
this one: "A valid variable name can only include spaces", so that I am
told specifically what is causing the problem. Yes, I know: I am a
validation freak :/ I hope you'll entertain this quirk of mine ;)

[x] ** When I add a variable, we need to clear the "add variable" form. Right
now, the new variable displays, but the values remain in the input fields.

[x] ** When I add a variable, and then I click the "change" icon: 1) the input
field appears empty, when it should be populated with the current value of
the variable ....

[x] ** If I then type a new value and click "save", the value appears between
quotes " ". This should not happen, since we don't use quotes for variable
values anywhere else.

* IMAGE_INSTALL_append

[x] ** In your latest commit, I cannot set a value for this variable. When I
click 'save', nothing happens. All other variables seem to be working fine.

- David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150115/c354c6c3/attachment.html>