[Toaster] [review-request] adamian/20150114-projectbuilds-6589

[Damian, Alexandru]

Thanks for the review -

I pushed out a new version, that fixes the error messages, and some of the
bugs.

However, due to the Build/BuildRequest duality, and limitations of the
Django QuerySet interface, the filters and ordering on errors/warnings will
take a lot of code to sort out correctly. I propose that we track this
particular filtering/ordering in a separate Bugzilla entry, and postpone it.

What do you think ?

Alex

On Wed, Jan 14, 2015 at 6:20 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

> There it goes:
>
> * Close the <small> tag in the heading
>
> * Hide the 'Machine' column by default and enable it in the edit columns
> menu
>
> * Sorting states are not being applied for the errors column, it sorts but
> the heading doesn't change styles. It also doesn't invert the sorting
>
> * Sorting by machine, target and time throws an error
>
> * Filtering by successful builds doesn't work
>
> * The yesterday's builds filter is showing todays' bulids
>
> * Filtering by builds with/without errors throws an error
>
> * When search returns no results the heading should change to "no builds
> found"
>
> * When you search or filter the heading needs to change to show the number
> of results returned
>
> Let me know if you have any questions.
>
> Cheers
>
> Belén
>
>
>
> On 14/01/2015 17:52, "Damian, Alexandru" <alexandru.damian at intel.com>
> wrote:
>
> >Hello,
> >
> >
> >Can you please review the project builds page patch, branch:
> >
> >
> >poky-contrib:adamian/20150114-projectbuilds-6589
> >
> >
> >Thank you,
> >Alex
> >
> >
> >
> >
> >--
> >Alex Damian
> >Yocto Project
> >
> >SSG / OTC
> >
> >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150115/1c38534a/attachment-0001.html>