[Toaster] [review-request] adamian/20150707_bugs

[Barros Pena, Belen]

Thanks, Alex. 

I have a couple of comments (inline).

On 07/07/2015 18:02, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:

>There are two new patches for review.
>
>
>- fixing the object updates on build requests that failed to start

Toaster now starts with a db that has failed build requests in it, and I
can see the information :)

I've attached a screenshot of what I see and it's a bit strange though.
First, I see 1 error and 1 exception, but only the exception has content
(the error is empty). I am not sure if this is just because the data was
logged before the changes you've made, or if there is something funny
going on. 

The second issue I have is presenting things like "Bitbake server did not
start in 5 seconds" as Toaster exceptions, since this is what caused the
whole thing to fail in the first place. I know that strictly this is
probably a Toaster exception, but I am not sure this sends the right
message to users. So what about a simple rule? If the build fails before
starting proper (at the build request stage), any Toaster exceptions are
presented as errors. If the build succeeds or fails past the build request
stage, we show Toaster exceptions as Toaster exceptions.

Would that we possible?


>- bug fixing for #7945 - loadconf excepts when called on file that does
>not live in git repo

The error I am seeing says:

Failure while trying to import the toaster config file: Error while
looking for remote "origin" in ""

Although I think I follow (because I know what the problem is), I am not
sure whether someone who doesn't know what's going on will get it. Could
we maybe say:

* "Toaster failed to import the selected configuration file" (this is just
to make the sentence shorter, to avoid abbreviations, and match the
language we use in the rest of the set up process)

* Then have two versions of this message: one when there is a value for
the Git URI, and another one when the Git URI is blank (like in this
case). The first one could stay as is, the second would say something
like: "Toaster did not find a Git repository. If you are using a Yocto
Project release tarball, please clone a Yocto Project repository instead."

The above is just a suggestion. If anybody can think of something better,
please say so

Thanks!

Belén

>
>
>
>
>Cheers,
>Alex
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: failed-build-request.png
Type: image/png
Size: 194603 bytes
Desc: failed-build-request.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150709/640ec334/attachment-0001.png>