[Toaster] [review-request][PATCH] bitbake: toaster: do not stop data import on bad data

Michael Wood michael.g.wood at intel.com
Wed Jul 15 03:52:21 PDT 2015


On 14/07/15 22:06, Brian Avery wrote:
> Continue storing layers in the database even if we hit
> a bad layer.
>
> [YOCTO #7955]
> ---
>   bitbake/lib/toaster/orm/models.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py
> index 4ea75f2..c218198 100644
> --- a/bitbake/lib/toaster/orm/models.py
> +++ b/bitbake/lib/toaster/orm/models.py
> @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
>                   dependlist[lv].append(Layer_Version.objects.get(layer_source = self, layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
>               except Layer_Version.DoesNotExist as e:
>                   print "Cannot find layer version ", self, ldi['dependency'], lv.up_branch
> -                raise e
> +                pass
>   
>           for lv in dependlist:
>               LayerVersionDependency.objects.filter(layer_version = lv).delete()

You can also remove the variable "e" to avoid an unused variable warning 
here.

(pylint will pick this up 
https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Python )



More information about the toaster mailing list