[Toaster] [review-request] ed/toaster/misc

[Ed Bartosh]

Hi Alex,

> > *toaster: Wait for toaster gui to come*
> > 
> >   I am not sure which logger should to be used here; the reason for
> > changing the logger in the first place (which was originally defined as
> > "BitBake" was that the "BitBake" logger settings are modified in
> > bitbake/lib/bb/__init__.py, and it is targeted at the inner Bitbake core;
> > some updates there changed the original output, with output disappearing
> > from the console being an obvious effect.
> > Messing with "BitBake" logger settings with  this may have side effects
> > throught the bitbake code, so I refrained from touching that
> > 
> >   I considered using the "toaster" logger that is defined in
> > bitbake/lib/toaster/toastermain/settings.py and outputs strictly to
> > console; I felt likewise reluctant to use this logger because changing it
> > to output to a file would be affect the way the django application is
> > logging.
> > 
> >   ToasterLogger is not defined anywhere, and this is why I used it here.
> And this apparently didn't work out well and caused "ToasterUI waiting for
> events" message to disappear from toaster_ui.log and be controller
> failing after 10 unsuccessful attempts to find this message in the log.
> 
> > I am not sure I understand the root cause of why the code breaks when using
> > "ToasterLogger" instead of "BitBake"; can you please assess the root cause
> > and get a solution to have messages properly logged to the toaster_ui.log
> > file using a logger that's not BitBake ?
> OK, I'll look at it. Meanwhile I'd suggest to accept this change because
> it's much better than previous one. It doesn't fix the root case, but it
> reverts the change that caused the bug.
>
The root cause of the issue was that logging level was not set for the
ToasterLogger. I've updated the patch:
https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ed/toaster/misc&id=6d1ddedaef28c0f17c2b821c3ceb077641fab772

Please, review.

--
Regards,
Ed