[Toaster] [review-request] adamian/20150727_fix_invalid_fields
Barros Pena, Belen
belen.barros.pena at intel.com
Wed Jul 29 04:02:08 PDT 2015
On 28/07/2015 15:02, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:
>Umm, the template shown here doesn't contain the fixes in the patch.
>
>
>Maybe a checkout problem ?
>
>The patch looks like:
>
>- <th class="{{tc.dclass}} {{tc.clclass}}">
>+ <th class="{%if tc.dclass%}{{tc.dclass}}{%endif%} {%if
>tc.clclass%}{{tc.clclass}}{%endif%}">
That patch only seems to touch the tablesort.html and
package_included_reverse_dependencies.html templates, but
package_included_detail.html is the one that's breaking on me
Cheers
Belén
>
>
>
>Cheers,
>
>Alex
>
>
>
>On Tue, Jul 28, 2015 at 12:14 PM, Barros Pena, Belen
><belen.barros.pena at intel.com> wrote:
>
>
>
>On 27/07/2015 17:56, "toaster-bounces at yoctoproject.org on behalf of
>Damian, Alexandru" <toaster-bounces at yoctoproject.org on behalf of
>alexandru.damian at intel.com> wrote:
>
>>This patch fixes invalid field usage in the package details page.
>>
>>
>>Can you please review and submit when possible ?
>>
>>adamian/20150727_fix_invalid_fields
>
>Mmm, this is still not working for me. The details page for packages
>installed in an image still returns the undefined variable error (see
>below). I wonder if I am doing something wrong :/
>
>Just to be sure, this is what I did: I built an image, went to the build
>dashboard, selected the image name from the left navigation, then a
>package from the table.
>
>Belén
>
>Environment:
>
>
>Request Method: GET
>Request URL:
>http://192.168.2.55:8000/toastergui/build/125/package_included_detail/74/3
>8
>285?count=25&orderby=path%3A%2B&page=1
>
>Django Version: 1.6
>Python Version: 2.7.6
>Installed Applications:
>('django.contrib.auth',
> 'django.contrib.contenttypes',
> 'django.contrib.messages',
> 'django.contrib.sessions',
> 'django.contrib.admin',
> 'django.contrib.staticfiles',
> 'django.contrib.humanize',
> 'bldcollector',
> 'toastermain',
> 'south',
> 'bldcontrol',
> 'orm',
> 'toastergui')
>Installed Middleware:
>('django.middleware.common.CommonMiddleware',
> 'django.contrib.sessions.middleware.SessionMiddleware',
> 'django.middleware.csrf.CsrfViewMiddleware',
> 'django.contrib.auth.middleware.AuthenticationMiddleware',
> 'django.contrib.messages.middleware.MessageMiddleware')
>
>
>Template error:
>In template
>/home/yocto/master/bitbake/lib/toaster/toastergui/templates/tablesort.html
>,
> error at line 21
> Undefined variable or unknown value for: "tc.dclass"
> 11 : </th>
>
>
> 12 : {% endfor %}
>
>
> 13 : </tr>
>
>
> 14 : </thead>
>
>
> 15 : {% else %}
>
>
> 16 : <table class="table table-bordered table-hover tablesorter"
>id="otable">
>
>
> 17 : <thead>
>
>
> 18 : <!-- Table header row; generated from "tablecols" entry in
>the context dict -->
>
>
> 19 : <tr>
>
>
> 20 : {% for tc in tablecols %}
>
>
> 21 : <th class=" {{tc.dclass}} {{tc.clclass}}">
>
>
> 22 : {%if tc.qhelp%}<i class="icon-question-sign
>get-help" title="{{tc.qhelp}}"></i>{%endif%}
>
>
> 23 : {%if tc.orderfield%}
>
>
> 24 : <a {%if tc.ordericon%} class="sorted"
>{%endif%}
>
>
> 25 : href="javascript:reload_params({'page': 1,
>'orderby' : '{{tc.orderfield}}' })" >
>
>
> 26 : {{tc.name <http://tc.name>}}
>
>
> 27 : </a>
>
>
> 28 : {%else%}
>
>
> 29 : <span class="muted">
>
>
> 30 : {{tc.name <http://tc.name>}}
>
>
> 31 : </span>
>
>
>Traceback:
>File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
>in get_response
> 114. response = wrapped_callback(request,
>*callback_args, **callback_kwargs)
>File "/home/yocto/master/bitbake/lib/toaster/toastergui/views.py" in
>package_included_detail
> 1770. response = render(request, template, context)
>File "/usr/local/lib/python2.7/dist-packages/django/shortcuts/__init__.py"
>in render
> 53. return HttpResponse(loader.render_to_string(*args, **kwargs),
>File "/usr/local/lib/python2.7/dist-packages/django/template/loader.py" in
>render_to_string
> 169. return t.render(context_instance)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 140. return self._render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>_render
> 134. return self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 123. return compiled_parent._render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>_render
> 134. return self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 123. return compiled_parent._render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>_render
> 134. return self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 123. return compiled_parent._render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>_render
> 134. return self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 62. result = block.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 62. result = block.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 62. result = block.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 62. result = block.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
>render
> 506. output = self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
>render
> 305. return nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render
> 155. return self.render_template(self.template, context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/loader_tags.py" in
>render_template
> 137. output = template.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 140. return self._render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>_render
> 134. return self.nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
>render
> 305. return nodelist.render(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>render
> 840. bit = self.render_node(node, context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render_node
> 78. return node.render(context)
>File
>"/usr/local/lib/python2.7/dist-packages/django/template/defaulttags.py" in
>render
> 196. nodelist.append(node.render(context))
>File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py" in
>render
> 88. output = self.filter_expression.resolve(context)
>File "/usr/local/lib/python2.7/dist-packages/django/template/base.py" in
>resolve
> 595. return
>settings.TEMPLATE_STRING_IF_INVALID % self.var
>File "/home/yocto/master/bitbake/lib/toaster/toastermain/settings.py" in
>__mod__
> 393. "Undefined variable or unknown value for: \"%s\"" %
>other)
>
>Exception Type: TemplateSyntaxError at
>/toastergui/build/125/package_included_detail/74/38285
>Exception Value: Undefined variable or unknown value for: "tc.dclass"
>
>
>
>>
>>
>>Cheers,
>>
>>Alex
>>
>>
>>--
>>Alex Damian
>>Yocto Project
>>
>>SSG / OTC
>>
>>
>>
>
>
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
More information about the toaster
mailing list