[Toaster] [review-request] michaelw/toaster/orm-split-up

[Damian, Alexandru]

I'm sorry, still will not pick this up.

I get this error when starting Toaster with an empty (new) database:

AlreadyRegistered at /toastergui/landing/

The model LayerSource is already registered

Environment:



Request Method: GET

Request URL: http://localhost:8000/toastergui/landing/


Django Version: 1.6.10

Python Version: 2.7.6

Installed Applications:

('django.contrib.auth',

 'django.contrib.contenttypes',

 'django.contrib.messages',

 'django.contrib.sessions',

 'django.contrib.admin',

 'django.contrib.staticfiles',

 'django.contrib.humanize',

 'bldcollector',

 'toastermain',

 'south',

 'bldcontrol',

 'orm',

 'toastergui')

Installed Middleware:

('django.middleware.common.CommonMiddleware',

 'django.contrib.sessions.middleware.SessionMiddleware',

 'django.middleware.csrf.CsrfViewMiddleware',

 'django.contrib.auth.middleware.AuthenticationMiddleware',

 'django.contrib.messages.middleware.MessageMiddleware')



Traceback:

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/core/handlers/base.py"
in get_response

  99.                 resolver_match = resolver.resolve(request.path_info)

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py"
in resolve

  337.             for pattern in self.url_patterns:

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py"
in url_patterns

  365.         patterns = getattr(self.urlconf_module, "urlpatterns",
self.urlconf_module)

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py"
in urlconf_module

  360.             self._urlconf_module = import_module(self.urlconf_name)

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/utils/importlib.py"
in import_module

  40.         __import__(name)

File "/home/ddalex/ssd/yocto/poky/bitbake/lib/toaster/toastermain/urls.py"
in <module>

  32. admin.autodiscover()

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/contrib/admin/__init__.py"
in autodiscover

  29.             import_module('%s.admin' % app)

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/utils/importlib.py"
in import_module

  40.         __import__(name)

File "/home/ddalex/venv/local/lib/python2.7/site-packages/django/contrib/admin/sites.py"
in register

  77.                 raise AlreadyRegistered('The model %s is already
registered' % model.__name__)


Exception Type: AlreadyRegistered at /toastergui/landing/

Exception Value: The model LayerSource is already registered




On Fri, Jun 19, 2015 at 4:14 PM, Michael Wood <michael.g.wood at intel.com>
wrote:

> OK, I've added a commit on this branch for step 1
>
> And will file a bug/patch in the autobuilder to update the url.
>
> Michael
>
> On 19/06/15 12:38, Damian, Alexandru wrote:
>
>> Hi,
>>
>> There is a slight problem with this approach.
>>
>> The AB is using the "/orm/eventfile" URL for uploading bitbake eventfiles
>> from running builds.
>> This patch changes that to "/bldcollector/eventfile", breaking the
>> interface for AB; therefore it cannot be taken as it is.
>>
>> I would suggest a 3-step approach:
>>
>> - make both the old and new URL work simultaneously, and have that
>> deployed on the toaster-ab-server
>> - patch the AB to use the new URL
>> - once the patch is deployed to AB and verified to be correctly used in
>> uploading data, delete the old URL mapping.
>>
>> Cheers,
>> Alex
>>
>>
>>
>> On Tue, Jun 16, 2015 at 6:16 PM, Michael Wood <michael.g.wood at intel.com
>> <mailto:michael.g.wood at intel.com>> wrote:
>>
>>     This is a slightly reduced scope version of the refactoring of the
>>     ORM that was discussed. The orm can continue to be a central place
>>     for database abstraction and the bldcollector can take over the
>>     function that was confusingly part of the orm application.
>>
>>     This reduces the changes from potentially /most/ files in toaster
>>     to a select few, as after looking at this the gain from changing
>>     more of the application doesn't outweigh the risk for regressions
>>     and potential disruption.
>>
>>     commit e35930be7c9fc99d5244c28c4f37eaece1615606
>>     Author: Michael Wood <michael.g.wood at intel.com
>>     <mailto:michael.g.wood at intel.com>>
>>     Date:   Tue Jun 16 16:00:26 2015 +0100
>>
>>         bitbake: toaster: split orm app into it's own module and app
>>
>>         The orm application was also the django application to collect
>>     the build
>>         information. Splitting this module up into it's functional
>>     parts. orm
>>         for the data module and bldcollector for build collection data.
>>
>>         [YOCTO #7706]
>>
>>         Signed-off-by: Michael Wood <michael.g.wood at intel.com
>>     <mailto:michael.g.wood at intel.com>>
>>
>>     --     _______________________________________________
>>     toaster mailing list
>>     toaster at yoctoproject.org <mailto:toaster at yoctoproject.org>
>>     https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>> ---------------------------------------------------------------------
>> Intel Corporation (UK) Limited
>> Registered No. 1134945 (England)
>> Registered Office: Pipers Way, Swindon SN3 1RJ
>> VAT No: 860 2173 47
>>
>> This e-mail and any attachments may contain confidential material for
>> the sole use of the intended recipient(s). Any review or distribution
>> by others is strictly prohibited. If you are not the intended
>> recipient, please contact the sender and delete all copies.
>>
>>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150625/7788d997/attachment-0001.html>