[Toaster] [review-request] Version3 6154 add sorting, searching, paging to recipe-package detail

[Damian, Alexandru]

Taken for submission, with whitespace changes.

Thanks,
Alex

On Thu, Mar 5, 2015 at 3:01 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

>
> On 04/03/2015 20:17, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
>
> >
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/recip
> >e_package_sort_6154
>
> The UI is looking good: I think Dave has fixed all issues.
>
> Thanks!
>
> Belén
>
> >
> >RR version 3 from Belen's review notes
> >> * In the no results page, the link says: "show all objects". It should
> >>say
> >> all packages (to match the heading, the tab, and what we do everywhere
> >> else)
> >>
> >> * When you search, the number of results is not shown anywhere. The
> >>number
> >> of results should show in a label next to the Package table heading. The
> >> design is explained on page 5 of this document
> >>
> >> https://bugzilla.yoctoproject.org/attachment.cgi?id=1810
> >
> >The last point (and last change block below) implement from page 5
> >above...
> >       We can use a badge instead, next to the first table
> >       heading (which will say "Package" or "File"). The
> >       badge shows the number of results returned by the search query:
> >
> >
> >Changes from Version 2:
> >toastergui> git diff
> >diff --git
> >a/bitbake/lib/toaster/toastergui/templates/detail_search_header.html
> >b/bitbake/lib/toaster/toastergui/templates/detail_search_header.html
> >index bab95d6..287d81b 100644
> >--- a/bitbake/lib/toaster/toastergui/templates/detail_search_header.html
> >+++ b/bitbake/lib/toaster/toastergui/templates/detail_search_header.html
> >@@ -39,7 +39,7 @@ $(document).ready(function() {
> >       <button type="submit" class="btn">Search</button>
> >   {% if objects.paginator.count == 0 %}
> >       <button type="submit" class="btn btn-link search-clear">
> >-        Show all objects
> >+        Show all {{search_what}}
> >       </button>
> >   {% endif %}
> >     </form>
> >diff --git
> >a/bitbake/lib/toaster/toastergui/templates/detail_sorted_header.html
> >b/bitbake/lib/toaster/toastergui/templates/detail_sorted_header.html
> >index 4f2c096..a7917dc 100644
> >--- a/bitbake/lib/toaster/toastergui/templates/detail_sorted_header.html
> >+++ b/bitbake/lib/toaster/toastergui/templates/detail_sorted_header.html
> >@@ -13,6 +13,9 @@
> >                 {%if tc.qhelp%}<i class="icon-question-sign get-help"
> >title="{{tc.qhelp}}"></i>{%endif%}
> >                 {%if tc.orderfield%}<a {%if tc.ordericon%}
> >class="sorted" {%endif%}href="javascript:reload_params({'page': 1,
> >'orderby' : '{{tc.orderfield}}' })" onclick="
> >                 {%if tc.ordericon%} <i
> >class="icon-caret-{{tc.ordericon}}"></i>{%endif%}
> >+                {% if request.GET.search and forloop.first %}
> >+                    <span class="badge
> >badge-info">{{objects.paginator.count}}</span>
> >+                {% endif %}
> >                 {%if tc.filter%}<div class="btn-group pull-right">
> >                     <a href="#filter_{{tc.filter.class}}" role="button"
> >class="btn btn-mini {%if
> >request.GET.filter%}{{tc.filter.options|filtered_icon:request.GET.filter}}
> >                 </div>{%endif%}
> >
> >
> >> -----Original Message-----
> >> From: Lerner, Dave
> >> Sent: Tuesday, March 03, 2015 4:53 PM
> >> To: Barros Pena, Belen (belen.barros.pena at intel.com); Damian, Alexandru
> >> (alexandru.damian at intel.com)
> >> Cc: toaster at yoctoproject.org
> >> Subject: [review-request] Version2 6154 add sorting, searching, paging
> >>to recipe-package
> >> detail
> >>
> >> http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> >> contrib/log/?h=lerner/recipe_package_sort_6154
> >>
> >> Implements fixes for 6154 recipe-packages detail sorting, searching,
> >>pagination.
> >>
> >> Tests:
> >> Viewing a qemux86 -64 core-image-full-cmdline build, then selection of
> >>     recipes -> (specified package) -> Packages tab
> >> Then verify:
> >>     traversal from packages to other 3 tabs works
> >>     packages in table
> >>         Size 1st sort descending
> >>         Package 1st sort ascending
> >>     no packages for recipe  (acl-native)
> >>         <package-version-rev> does not build any packages
> >>     < 10 packages (at)
> >>         verify no pagination widgets
> >>         verify no search bear
> >>     more than 500 packages glibc-locale
> >>         verify only pages 1-5 appear
> >>         verify picking page 5 centers page 5, same for page 7
> >>             then selecting size reverts back to page 1, descendant size
> >>     search with results
> >>         gives right set
> >>         can add to search text string
> >>         remove [x] button deletes string and resets to unfiltered serch
> >>     search without results
> >>         No <packages> found
> >>         show all objects button clicked shows  original 1st page
> >>
> >> Wc3 Validator
> >> all pages show 2 errors in build popover, these errors ignored for this
> >>review.
> >>
> >>     < 10 packages(at) : ok
> >>     only 1 page of packages (acl) > 10 : ok
> >>     no packages for recipe  (acl-native) : ok
> >>     more than 500 packages (glibc-locale) page 7 : ok
> >>     result from empty search : ok
> >>
> >> Comparison with defect attached spec: ok
> >>
> >> Comparison tag layout with Layer Detail Target Page:
> >>   span11, page-header, h1 : expected difference, recipe simpler
> >>   span7
> >>     alertarea, dismiss alert : expected difference, not in recipe page
> >>     tabcontent button-place : expected diff, not in recipe
> >>         (targets/packages-built), table : expected diff, recipe adds
> >>tablesorter
> >>     pagination : expected diff, recipe uses reload_params, targets
> >>selfref href
> >>
> >> Comparison with layer Detail Page, empty search result:
> >>     no diffs in appearance
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150309/8a776553/attachment-0001.html>