[Toaster] [review-request] dreyna/IMAGE_INSTALL_append_space_7394

[Barros Pena, Belen]

On 13/03/2015 00:17, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belén,
> 
>I have completed what I think is the minimal implementation for this fix.
> 
>    dreyna/IMAGE_INSTALL_append_space_7394
> 
>  * It insures that any non-empty value update has a space prefix.
>  * It insures that any non-empty value in the edit box has a space
>prefix, to guide the user.
>  * I also caught an edge case, where I now suppress the ³Save² button
>when only spaces are entered
>  * There is also a white space fix
> 
>Note:
>  * I did not force the leading space in this value to show in the page
>(i.e. I let the HTML trim it). It would visually offset the value by one
>position from the other values, and it would require us to do ³ ²
>substitutions, and I thought that the
> added complexity not worth the effort. If you really want it I could do
>either ³<pre></pre>²or use the template ³{{
>image_install_append|replace:"/
> / " }}²

No, no: I agree the space should not be shown. This is looking good on my
side of things.

Thanks!

Belén

> 
>- David
> 
>