[Toaster] [review-request] dreyna/IMAGE_INSTALL_append_space_7394

[Barros Pena, Belen]

On 14/03/2015 02:42, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belén,
>
>> But the form seems
>> to trim any extra spaces you might add by mistake, so this makes the
>>issue
>> just a tiny cosmetic thing.
>
>I actually had the code normalize this value by always trimming all
>outside spaces and then inserting the prefix space.
>
>If you want, I can certainly preserve extra spaces.

No, no: I think trimming them is the right thing to do.

Thanks!

Belén

>
>- David
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> Sent: Friday, March 13, 2015 10:31 AM
>> To: Reyna, David; DAMIAN, ALEXANDRU
>> Cc: toaster at yoctoproject.org
>> Subject: Re: [Toaster] [review-request]
>> dreyna/IMAGE_INSTALL_append_space_7394
>>
>>
>>
>> On 13/03/2015 00:17, "Reyna, David" <david.reyna at windriver.com> wrote:
>>
>> >Hi Belén,
>> >
>> >I have completed what I think is the minimal implementation for this
>>fix.
>> >
>> >    dreyna/IMAGE_INSTALL_append_space_7394
>> >
>> >  * It insures that any non-empty value update has a space prefix.
>> >  * It insures that any non-empty value in the edit box has a space
>> >prefix, to guide the user.
>> >  * I also caught an edge case, where I now suppress the ³Save² button
>> >when only spaces are entered
>> >  * There is also a white space fix
>> >
>> >Note:
>> >  * I did not force the leading space in this value to show in the page
>> >(i.e. I let the HTML trim it). It would visually offset the value by
>>one
>> >position from the other values, and it would require us to do ³ ²
>> >substitutions, and I thought that the
>> > added complexity not worth the effort. If you really want it I could
>>do
>> >either ³<pre></pre>²or use the template ³{{
>> >image_install_append|replace:"/
>> > / " }}²
>> >
>> >- David
>> >
>> >
>>
>> This looks good to me. The only strange bit is that, even though you are
>> not showing the space in the page (which I agree is the right thing to
>> do), when you click the change icon the space is there. But the form
>>seems
>> to trim any extra spaces you might add by mistake, so this makes the
>>issue
>> just a tiny cosmetic thing.
>>
>> Thanks!
>>
>> Belén
>>
>> >
>>
>