[Toaster] V2: [review-request] dreyna/PACKAGE_CLASSES_current_value_7448

[Barros Pena, Belen]

On 22/03/2015 08:43, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belén,
>
>I have tested, rebased, and pushed your suggested changes.
>
>    dreyna/PACKAGE_CLASSES_current_value_7448

So I guess this is ready to submit, then.

Thanks!

Belén

>
>- David
>
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> Sent: Friday, March 20, 2015 4:05 AM
>> To: Reyna, David
>> Cc: toaster at yoctoproject.org
>> Subject: Re: [Toaster] [review-request]
>> dreyna/PACKAGE_CLASSES_current_value_7448
>>
>>
>>
>> On 19/03/2015 16:21, "Reyna, David" <david.reyna at windriver.com> wrote:
>>
>> >> This is not working for me.
>> >
>> >Hmm.
>> >
>> >I had found that extra "#" characters were causing syntax errors. Do
>>you
>> >see that patch change in your code?
>>
>> Yes: it is there.
>>
>> Playing with it a bit, I realised that this was not related to the
>> package_rpm value. The value would never be picked up the first time you
>> clicked the 'change' button after loading the page, but I am not sure
>>why.
>>
>> I rewrote the function using exactly the same logic but with jQuery
>>syntax
>> and the prop() function to set the selected option in the dropdown menu,
>> and it seems to be working for me now. The patch is here:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>> contrib/commit/?h=bbarrosp/p
>> ackage-classes&id=0bc50d425e52a66216ef97087f019c654f2fce4d
>>
>> Now, there might be a much better way of doing this. I wouldn't know.
>>
>> The other thing I've noticed is that your branch still has the typo
>> 'package_dev' (it should be package_deb). The typo is fixed in current
>> master, so I'd say you'll need to rebase before resubmitting for review.
>>
>> Cheers
>>
>> Belén
>>
>>
>> >
>> >diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html
>> >b/bitbake/lib/toaster/toastergui/templates/projectconf.html
>> >index c994f31..5873395 100644
>> >--- a/bitbake/lib/toaster/toastergui/templates/projectconf.html
>> >+++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html
>> >@@ -702,8 +702,8 @@
>> >if (0 == value.indexOf("package_rpm")) {
>> >$('select').selectedIndex = 2;
>> >updatePackageClassCheckboxes();
>> >- if (0 < value.indexOf("package_dev"))
>> >{document.getElementById("#package_class_1_input").checked = true;};
>> >- if (0 < value.indexOf("package_ipk"))
>> >{document.getElementById("#package_class_2_input").checked = true;};
>> >+ if (0 < value.indexOf("package_dev"))
>> >{document.getElementById("package_class_1_input").checked = true;};
>> >+ if (0 < value.indexOf("package_ipk"))
>> >{document.getElementById("package_class_2_input").checked = true;};
>> >}
>> >});
>> >
>> >- David
>> >
>> >> -----Original Message-----
>> >> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> >> Sent: Thursday, March 19, 2015 5:57 AM
>> >> To: Reyna, David; DAMIAN, ALEXANDRU
>> >> Cc: toaster at yoctoproject.org
>> >> Subject: Re: [Toaster] [review-request]
>> >> dreyna/PACKAGE_CLASSES_current_value_7448
>> >>
>> >>
>> >>
>> >> On 18/03/2015 01:59, "Reyna, David" <david.reyna at windriver.com>
>>wrote:
>> >>
>> >> >Hi Belén,
>> >> >
>> >> >A simple fix for 7448 ³PACKAGE_CLASSES variable does not show
>>current
>> >> >value when editing²:
>> >> >
>> >> >    dreyna/PACKAGE_CLASSES_current_value_7448
>> >>
>> >> This is not working for me. When the value is set to package_rpm, I
>> >>still
>> >> see package_deb selected in the dropdown menu when I click the
>>'change'
>> >> icon.
>> >>
>> >> Cheers
>> >>
>> >> Belén
>> >>
>> >> >
>> >> >- David
>> >> >
>> >> >
>> >>
>> >
>>
>