[Toaster] [review-request][PATCH] bitbake: toaster: Project page fix targets url and tooltip placement

[Damian, Alexandru]

Taken for submission,

Thank you,
Alex

On Thu, Mar 19, 2015 at 11:48 AM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

>
> On 19/03/2015 11:09, "Michael Wood" <michael.g.wood at intel.com> wrote:
>
> >Make sure we point to the all targets page for the notification links.
> >Also fix the tooltip placements and a minor typo on the targets page.
> >
> >[YOCTO #7480]
>
> It all looks good to me. Thanks for catching the typo!
>
> Belén
>
> >
> >Signed-off-by: Michael Wood <michael.g.wood at intel.com>
> >---
> > bitbake/lib/toaster/toastergui/templates/project.html | 4 ++--
> > bitbake/lib/toaster/toastergui/templates/targets.html | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/bitbake/lib/toaster/toastergui/templates/project.html
> >b/bitbake/lib/toaster/toastergui/templates/project.html
> >index badc8a6..f81517b 100644
> >--- a/bitbake/lib/toaster/toastergui/templates/project.html
> >+++ b/bitbake/lib/toaster/toastergui/templates/project.html
> >@@ -299,7 +299,7 @@ vim: expandtab tabstop=2
> >         <a href="{% url 'importlayer' %}">Import layer</a></p>
> >       <ul class="unstyled configuration-list">
> >           <li ng-repeat="l in layers track by l.id"
> >class="animate-repeat">
> >-            <a href="{[l.layerdetailurl]}" class="layer-info"
> >data-toggle="tooltip" tooltip="{[l.giturl]} |
> >{[l.branch.name]}">{[l.name]}</a>
> >+            <a href="{[l.layerdetailurl]}" class="layer-info"
> >data-toggle="tooltip" tooltip-placement="right" tooltip="{[l.giturl]} |
> >{[l.branch.name]}">{[l.name]}</a>
> >             <i class="icon-trash" ng-click="layerDel(l.id)"
> >tooltip="Delete"></i>
> >                       </li>
> >       </ul>
> >@@ -434,7 +434,7 @@ angular.element(document).ready(function() {
> >   scope.urls.xhr_edit = "{% url 'xhr_projectedit' project.id %}";
> >   scope.urls.xhr_datatypeahead = "{% url 'xhr_datatypeahead' %}";
> >   scope.urls.layers = "{% url 'layers' %}";
> >-  scope.urls.targets = "{% url 'targets' %}";
> >+  scope.urls.targets = "{% url 'all-targets' %}";
> >   scope.urls.importlayer = "{% url 'importlayer'%}";
> >   scope.urls.layer = "{% url 'base_layerdetails' %}";
> >   scope.project = {{prj|json}};
> >diff --git a/bitbake/lib/toaster/toastergui/templates/targets.html
> >b/bitbake/lib/toaster/toastergui/templates/targets.html
> >index f918d6c..27ff2be 100644
> >--- a/bitbake/lib/toaster/toastergui/templates/targets.html
> >+++ b/bitbake/lib/toaster/toastergui/templates/targets.html
> >@@ -38,7 +38,7 @@
> >   {% else %}
> >     <div class="alert alert-info">
> >       <p class="lead">
> >-       Toaster has not target information. To generate target
> >information you can:<br/>
> >+       Toaster has no target information. To generate target information
> >you can:<br/>
> >        <ul class="lead">
> >        <li style="margin-top: 10px"> <a
> >href="
> https://wiki.yoctoproject.org/wiki/Setting_up_a_hosted_managed_mode_
> >for_Toaster#LayerSources">Configure a layer source</a></li>
> >        <li style="margin-top: 10px">  <a href="{% url 'importlayer'
> >%}">Import a layer</a></li>
> >--
> >2.1.0
> >
> >--
> >_______________________________________________
> >toaster mailing list
> >toaster at yoctoproject.org
> >https://lists.yoctoproject.org/listinfo/toaster
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150324/37b065fb/attachment.html>