[Toaster] [review-request] adamian/20150515_fix_table_header

[Barros Pena, Belen]

On 19/05/2015 16:27, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:

>Hi,
>
>
>Can you please review this branch ? It brings in an important piece of
>refactoring to move Toaster towards the REST-style API that will enable a
>cleaner design and support for interconnection
> with other systems.
>
>
>Getting into details, the "New build" button in all the pages, bar the
>project page, now fetches data using the projects API, which is just the
>"all projects" page in machine-readable format.

Hi Alex:

I've looked at the UI, and I've found some issues with the interaction of
the new build button. Here comes a list:

* When no project is selected, the recipe input field is disabled, but the
build button is enabled, which looks a bit strange. We would need to
disable the build button as well while no project is selected

* When no project is selected, the 'Cancel' link needs to be disabled.
Otherwise you end up in a weird state you cannot get out of.


* The project name autocomplete now works, but when I select a project,
the 'change' icon is missing, which means I am stuck: I cannot select a
different project. The change icon needs to show next to the project name,
except when the number of projects in the Toaster instance is one.

* The recipes autocomplete is not working for me, but maybe it's not
related to this branch.

* If I select a project, then refresh the page, the page has forgotten
about the project I just selected. It would be nice to remember the last
project I chose. 

Thanks!

Belén

> This cleans up a bit the overloading of the xhr_datatypeahead; after the
>API refactoring, all xhr_ calls should be completely replaced with proper
>calls to the REST endpoints.
>
>
>The code is here:
>https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/201
>50515_fix_table_header
>
>
>
>Incidentally, this patch fixes the "new build" breakage by the first
>round of URL refactoring, and the "construction" of URLs on the client
>side.
>
>
>Can you please review and comment ?
>
>Cheers,
>Alex
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>