[Toaster] [review-request] adamian/20150515_fix_table_header

[Damian, Alexandru]

Taken for submission with the last extra patch from Michael.

Cheers,
Alex

On Fri, May 15, 2015 at 5:52 PM, Michael Wood <michael.g.wood at intel.com>
wrote:

>
> This wouldn't be valid html as it'll do:
>
> <thead id="tableheader">
>     <th>dog</th>
> </thead>
>
> When it should be
>
> <thead id="tableheader">
>    <tr>
>        <th>dog</th>
>     </tr>
> </thead>
>
> Just put an empty <th> in the <tr> that should be valid then.
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/toastertable.html
> b/bitbake/lib/toaster/toastergui/templates/toastertable.html
> index 598d295..d68d093 100644
> --- a/bitbake/lib/toaster/toastergui/templates/toastertable.html
> +++ b/bitbake/lib/toaster/toastergui/templates/toastertable.html
> @@ -93,6 +93,7 @@
>    <!-- The actual table -->
>    <table class="table table-bordered table-hover tablesorter"
> id="{{table_name}}">
>      <thead>
> +      <tr><th></th></tr>
>      </thead>
>      <tbody></tbody>
>    </table>
>
>
> Michael
>
>
> On 15/05/15 14:45, Damian, Alexandru wrote:
>
>> Hi,
>>
>> This patch brings back table header in the toastertable - based pages.
>>
>> Can you please review ?
>>
>> Thank you,
>> Alex
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150521/cb278add/attachment.html>