[Toaster] [review-request][PATCH 0/2] remove SDKMACHINE variable

[Barros Pena, Belen]

On 04/11/2015 12:11, "toaster-bounces at yoctoproject.org on behalf of Ed
Bartosh" <toaster-bounces at yoctoproject.org on behalf of
ed.bartosh at linux.intel.com> wrote:


>Hi,
>
>This patchset contains two identical changes for toasterconf.json:
>removing
>SDKMACHINE variable. Variable is not used in toaster anymore as it's
>removed
>by this change: 
>https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html
>
>The patchset logically belongs to my previous patchset: 8279: Provide a
>single way of starting Toaster
>I'm sending this in separate e-mail as below two patches should be send
>to different upstream projects:
>openembedded-core and yocto.
>
>Please, send them after my previous patchset is accepted.
>
>The following changes since commit
>fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>
>  build-appliance-image: Update to jethro head revision (2015-11-03
>14:03:03 +0000)
>
>are available in the git repository at:
>
>  git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
>  
>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove
>-sdkmachine

Mmmm, it complains when importing the meta-yocto toasterconf.json file.
This is the error:

Importing file: /home/yocto/master/meta-yocto/conf/toasterconf.json
Failure while trying to import the toaster config file
/home/yocto/master/meta-yocto/conf/toasterconf.json: Expecting property
name: line 8 column 5 (char 216)
Traceback (most recent call last):
File 
"/home/yocto/master/bitbake/lib/toaster/bldcontrol/management/commands/chec
ksettings.py", line 110, in _verify_be
LoadConfigCommand()._import_layer_config(config_file)
File 
"/home/yocto/master/bitbake/lib/toaster/bldcontrol/management/commands/load
conf.py", line 42, in _import_layer_config
data = json.loads(open(filepath, "r").read())
File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
obj, end = self.scan_once(s, idx)

Cheers

Belén

>
>Ed Bartosh (2):
>  toasterconf: remove SDKMACHINE variable
>  toasterconf: remove SDKMACHINE variable
>
> meta-yocto/conf/toasterconf.json | 1 -
> meta/conf/toasterconf.json       | 1 -
> 2 files changed, 2 deletions(-)
>
>--
>Regards,
>Ed
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster