[Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

[Barros Pena, Belen]

On 06/11/2015 07:56, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Ed and Belén,
>
>> Specifically, this variable is also coded into these two files:
>>   views.py
>>   templates/projectconf.html
>
>If you want, I can take this task on and remove references to SDKMACHINE
>from these files, given that I am the one who put them in in the first
>place.

Looks like we need some changes in the template. The variable does not
display in the BitBake variables page (as expected, since it is no longer
set in the default configuration), but if you add it, you cannot delete it
(the 'delete' icon is missing). David: since you are familiar with that
template, do you think you could take care of this? When SDKMACHINE is not
defined, you should be able to add it and delete it like any other
variable using the 'add variable' form and the delete icon.

I can open a Bugzilla entry to track the work if you want me to.

Thanks!

Belén

 
>
>- David
>
>> -----Original Message-----
>> From: Reyna, David
>> Sent: Thursday, November 05, 2015 9:41 AM
>> To: 'Ed Bartosh'; toaster at yoctoproject.org
>> Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>> 
>> Hi Ed,
>> 
>> Have you tested this patch against the project configure variables
>> page?
>> 
>> Specifically, this variable is also coded into these two files:
>> 
>>   views.py
>>   templates/projectconf.html
>> 
>> Are these files being handled in a separate commit?
>> 
>> - David
>> 
>> 
>> > -----Original Message-----
>> > From: toaster-bounces at yoctoproject.org [mailto:toaster-
>> > bounces at yoctoproject.org] On Behalf Of Ed Bartosh
>> > Sent: Thursday, November 05, 2015 9:23 AM
>> > To: toaster at yoctoproject.org
>> > Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable
>> >
>> > Hi,
>> >
>> > This patchset contains two identical changes for toasterconf.json:
>> > removing
>> > SDKMACHINE variable. Variable is not used in toaster anymore as it's
>> > removed
>> > by this change:
>> https://lists.yoctoproject.org/pipermail/toaster/2015-
>> > October/003234.html
>> >
>> > The patchset logically belongs to my previous patchset: 8279:
>> Provide
>> > a single way of starting Toaster
>> > I'm sending this in separate e-mail as below two patches should be
>> > send to different upstream projects:
>> > openembedded-core and yocto.
>> >
>> > Please, send them after my previous patchset is accepted.
>> >
>> > Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
>> > "package_rpm"
>> >
>> > The following changes since commit
>> > fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:
>> >
>> >   build-appliance-image: Update to jethro head revision (2015-11-03
>> > 14:03:03 +0000)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-
>> sdkmachine
>> >   http://git.yoctoproject.org/cgit.cgi/poky-
>> > contrib/log/?h=ed/toaster/remove-sdkmachine
>> >
>> > Ed Bartosh (2):
>> >   toasterconf: remove SDKMACHINE variable
>> >   toasterconf: remove SDKMACHINE variable
>> >
>> >  meta-yocto/conf/toasterconf.json | 3 +--
>> >  meta/conf/toasterconf.json       | 3 +--
>> >  2 files changed, 2 insertions(+), 4 deletions(-)
>> >
>> > --
>> > Regards,
>> > Ed
>> >
>> > --
>> > _______________________________________________
>> > toaster mailing list
>> > toaster at yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/toaster