[Toaster] [review-request][PATCH 0/9] Implement UI changes for "command line builds" project

[Barros Pena, Belen]

On 02/10/2015 18:46, "toaster-bounces at yoctoproject.org on behalf of Elliot
Smith" <toaster-bounces at yoctoproject.org on behalf of
elliot.smith at intel.com> wrote:

>This implements changes across the UI to hide irrelevant options
>for command-line builds, and show additional help icons explaining
>why those options are hidden.
>
>For details of the changes, see the document attached to bug 8231
>at https://bugzilla.yoctoproject.org/attachment.cgi?id=2760.
>
>Notes:
>
>* One of the changes in the design document has not been implemented:
>it's not possible to hide the "customise image recipe" links and
>buttons (page 9) as these are not in the templates yet.
>
>* The visual design differs slightly from the design document, as it
>incorporates a new layout for the build dashboard which is not
>implemented yet.
>
>* The "New build" button is displayed on the command line
>builds project page, as we came to the conclusion that the logic
>in the JavaScript (i.e. show the new build button if there is no
>build input form on the page) should apply in the case of the
>builds page for the "command line builds" project.
>
>Changes since af1e3160922a30b8a538959335a5f8945f2f3549 (toaster-next) are
>in
>git://git.yoctoproject.org/poky-contrib, elliot/toaster/cli_builds_ui-8231
>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/cl
>i_builds_ui-8231

Hi Elliot,

This is looking pretty good. I have a couple of small comments though:

* Changing the project name only works on page refresh. When I click the
'save' button nothing happens, but when I refresh the page, the name has
changed. I've checked, and I don't think this is happening on master.

* the 'new build' button in Command like builds project page shows the
'Command line builds' project selected. That project should never be
selected in that new build form. Instead, the form in that project should
behave as in the 'all builds' and 'all projects' pages (at the moment, no
project selected, although we know that't not ideal either).

* in fact, if the only project that exists in the Toaster instance is the
'Command line builds' project, the 'new build' button should really not
show at all. It's just noise: you cannot really interact with it in any
way. Sorry: I forgot to think of this case when putting together the design

Any questions, let me know.

Thanks!

Belén


>
>Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8231
>
>Elliot Smith (9):
>  toaster: Reorganise and lint tests
>  toaster: Replace "Run again" button with help text for cli builds
>  toaster: Show 'not applicable' for default project machine and release
>  toaster: Make the builds view the project page for "command line
>    builds"
>  toaster: Hide tabs and add info popups for command line builds
>  toaster: Show tooltip next to cli builds project name in all builds
>  toaster: More linting of tests
>  toaster: Clean up template code
>  toaster: Exclude "command line builds" project from projects typeahead
>
> .../lib/toaster/toastergui/static/css/default.css  |   5 +
> bitbake/lib/toaster/toastergui/templates/base.html |   5 +-
> .../lib/toaster/toastergui/templates/builds.html   |  19 +-
> .../toaster/toastergui/templates/mrb_section.html  |  66 +++--
> .../lib/toaster/toastergui/templates/projects.html |  23 +-
> .../toastergui/templates/projecttopbar.html        |  80 +++---
> .../toastergui/templatetags/project_url_tag.py     |  34 +++
> bitbake/lib/toaster/toastergui/tests.py            | 311
>+++++++++++++++++----
> bitbake/lib/toaster/toastergui/typeaheads.py       |   4 +-
> 9 files changed, 420 insertions(+), 127 deletions(-)
> create mode 100644
>bitbake/lib/toaster/toastergui/templatetags/project_url_tag.py
>
>--
>Elliot Smith
>Software Engineer
>Intel OTC
>
>---------------------------------------------------------------------
>Intel Corporation (UK) Limited
>Registered No. 1134945 (England)
>Registered Office: Pipers Way, Swindon SN3 1RJ
>VAT No: 860 2173 47
>
>This e-mail and any attachments may contain confidential material for
>the sole use of the intended recipient(s). Any review or distribution
>by others is strictly prohibited. If you are not the intended
>recipient, please contact the sender and delete all copies.
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster