[Toaster] [review-request][PATCH 0/2][v2] Fix cooker log download button

[Barros Pena, Belen]

On 05/10/2015 14:39, "toaster-bounces at yoctoproject.org on behalf of Elliot
Smith" <toaster-bounces at yoctoproject.org on behalf of
elliot.smith at intel.com> wrote:

>This supersedes 
>https://lists.yoctoproject.org/pipermail/toaster/2015-September/002877.htm
>l
>(which was a single commit).
>
>* Retrieve a build's log file location directly from the file system,
>as the one which is available at the time of the BuildStarted event
>is incorrect.
>
>* Hide the "Download build log" button for builds which fail early
>(e.g. due to recipe parsing) and consequently have no cooker_log_path.
>
>Changes since 986f6b04b26bba9d01393f8f4ced4e0f4385368a (toaster-next) are
>in
>git://git.yoctoproject.org/poky-contrib, elliot/toaster/wrong_log-8373
>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/wr
>ong_log-8373

These builds not only have no log: they also have no build data. That's
why they should look like this:

http://www.yoctoproject.org/toaster/build-dashboard-failed-build-request.ht
ml


We should remove not only the 'download log' button, but also the left
navigation and the 'build summary section'. It's all explained in this
document:

https://bugzilla.yoctoproject.org/attachment.cgi?id=2781

Cheers

Belén

>
>Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373
>
>Elliot Smith (2):
>  toaster: Manually retrieve log file location from filesystem
>  toaster: Hide "Download build log" button if log doesn't exist
>
> bitbake/lib/bb/ui/toasterui.py                     | 31
>+++++++++++++++++++++-
> .../toastergui/templates/builddashboard.html       |  4 ++-
> 2 files changed, 33 insertions(+), 2 deletions(-)
>
>--
>Elliot Smith
>Software Engineer
>Intel OTC
>
>---------------------------------------------------------------------
>Intel Corporation (UK) Limited
>Registered No. 1134945 (England)
>Registered Office: Pipers Way, Swindon SN3 1RJ
>VAT No: 860 2173 47
>
>This e-mail and any attachments may contain confidential material for
>the sole use of the intended recipient(s). Any review or distribution
>by others is strictly prohibited. If you are not the intended
>recipient, please contact the sender and delete all copies.
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster