[Toaster] [review-request][PATCH 3/3] toaster: Don't store table data in the browser
Michael Wood
michael.g.wood at intel.com
Tue Oct 6 09:08:50 PDT 2015
Just for the record this patch set was submitted upstream (I updated the
wrong thread)
Michael
On 01/10/15 10:33, Elliot Smith wrote:
> As table data is no longer loaded from the history stack
> (it's refreshed from the server on navigation), remove
> the onpopstate event handler and the code which pushes
> the page data onto the stack.
>
> [YOCTO #7660]
>
> Signed-off-by: Elliot Smith <elliot.smith at intel.com>
> ---
> bitbake/lib/toaster/toastergui/static/js/table.js | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/table.js b/bitbake/lib/toaster/toastergui/static/js/table.js
> index 99b99a0..b30b552 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/table.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/table.js
> @@ -33,14 +33,6 @@ function tableInit(ctx){
>
> loadData(tableParams);
>
> - window.onpopstate = function(event){
> - if (event.state){
> - tableParams = event.state.tableParams;
> - /* We skip loadData and just update the table */
> - updateTable(event.state.tableData);
> - }
> - };
> -
> function loadData(tableParams){
> $.ajax({
> type: "GET",
> @@ -49,10 +41,6 @@ function tableInit(ctx){
> headers: { 'X-CSRFToken' : $.cookie('csrftoken')},
> success: function(tableData) {
> updateTable(tableData);
> - window.history.replaceState({
> - tableData: tableData,
> - tableParams: tableParams
> - }, null, libtoaster.dumpsUrlParams(tableParams));
> }
> });
> }
More information about the toaster
mailing list