[Toaster] [review-request][PATCH] 8187 The project builds table is showing all builds instead of the project builds

[Barros Pena, Belen]

On 02/09/2015 10:27, "Smith, Elliot" <elliot.smith at intel.com> wrote:

>Hello David. Thanks for the patch.
>
>
>Could you please rebase this on master, as it has changed quite a bit in
>the last couple of days?

Rebasing should sort out the redirect issue you are seeing and not being
able to reach the project builds page. That's fixed in master.

>
>
>Note: my preference would be to have _build_list_helper() take an
>optional pid keyword parameter (default = None), rather than pass 0 as a
>fake pid.
>
>
>Thanks.
>Elliot
>
>
>On 2 September 2015 at 08:49, Reyna, David
><david.reyna at windriver.com> wrote:
>
>Hi Belén,
>
>Please find the patch for 8187 here:
>
>  dreyna/project_builds_8187
>
>There were several issues blocking this view, which I will detail in the
>defect.
>
>BTW, I kept the last column 'project name' as-is even though the entire
>page is under that project name, so that I would not have to mess with
>the common header template.

It really makes no sense to show that column: all builds in that table
belong to the same project, so those values are just noise. Maybe we could
hide the column if the page is the project builds page, and show it only
when the page is the all builds page.

Cheers

Belén

>
>
>--
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>-- 
>Elliot Smith
>Software Engineer
>Intel Open Source Technology Centre
>
>
>