[Toaster] [review-request][PATCH 0/3] Hide irrelevant builds

[Barros Pena, Belen]

On 03/09/2015 03:14, "Brian Avery" <avery.brian at gmail.com> wrote:

>A bug (small):
>In progress build does not appear on the project build page until it
>has completed. The # next to the builds(##) at the top of the page
>shows 1 even during the build.

https://www.dropbox.com/s/z5iv03fmn0mhehx/Screenshot%202015-09-02%2017.39.4
1.png?dl=0

This is a bug (thanks for spotting it): it should be showing 0. Builds are
not shown in tables or added to counters until they complete. When you
have a project with a build in progress and 0 builds completed, the page
should look as shown in the attached file.


Cheers

Belén



>
>-b
>
>On Wed, Sep 2, 2015 at 7:11 PM, Brian Avery <avery.brian at gmail.com> wrote:
>> Question:
>> How does this interact with the default_proj you did?  I couldn't
>> apply this patchset on top of that one and I upstreamed the
>> default_proj first.
>>
>> When I did a quick apply by hand, I got errors when I tried to go look
>> at the "command line proj" page, but that may have been my mistake.
>>
>> We should probably make sure that this interacts ok with the
>> default_proj changes.
>> -b
>>
>> On Wed, Sep 2, 2015 at 9:22 AM, Barros Pena, Belen
>> <belen.barros.pena at intel.com> wrote:
>>>
>>>
>>> On 02/09/2015 17:04, "toaster-bounces at yoctoproject.org on behalf of
>>>Elliot
>>> Smith" <toaster-bounces at yoctoproject.org on behalf of
>>> elliot.smith at intel.com> wrote:
>>>
>>>>Hide "in progress" builds everywhere, and only show builds for
>>>>the currently-open project on the /project/X/builds page.
>>>>
>>>>Changes since 71b0568fa43285f0946fae93fb43cea5f3bbecec are in
>>>>git://git.yoctoproject.org/poky-contrib,
>>>>elliot/toaster/hide_builds-8236
>>>>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster
>>>>/hi
>>>>de_builds-8236
>>>
>>> The UI seems to be working correctly:
>>>
>>> * Builds in progress no longer show
>>> * Only the builds for the selected project are shown
>>>
>>> The latter means that this bug also fixes
>>>
>>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=8187
>>>
>>> Which was assigned to David Reyna, who had a patch out for review, I
>>> believe.
>>>
>>> Just bringing it up so you can decide which one should go in.
>>>
>>> Cheers
>>>
>>> Belén
>>>
>>>>
>>>>Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8236
>>>>
>>>>Alexandru DAMIAN (1):
>>>>  toaster: hide irrelevant builds in the project builds view
>>>>
>>>>Elliot Smith (2):
>>>>  toaster: Remove cast to date which causes errors during test
>>>>  toaster: Add tests for /project/X/builds page
>>>>
>>>> bitbake/lib/toaster/toastergui/tests.py | 91
>>>>++++++++++++++++++++++++++++++++-
>>>> bitbake/lib/toaster/toastergui/views.py | 59 +++++++++++++++------
>>>> bitbake/toaster-requirements.txt        |  1 +
>>>> 3 files changed, 134 insertions(+), 17 deletions(-)
>>>>
>>>>--
>>>>Elliot Smith
>>>>Software Engineer
>>>>Intel OTC
>>>>
>>>>---------------------------------------------------------------------
>>>>Intel Corporation (UK) Limited
>>>>Registered No. 1134945 (England)
>>>>Registered Office: Pipers Way, Swindon SN3 1RJ
>>>>VAT No: 860 2173 47
>>>>
>>>>This e-mail and any attachments may contain confidential material for
>>>>the sole use of the intended recipient(s). Any review or distribution
>>>>by others is strictly prohibited. If you are not the intended
>>>>recipient, please contact the sender and delete all copies.
>>>>
>>>>--
>>>>_______________________________________________
>>>>toaster mailing list
>>>>toaster at yoctoproject.org
>>>>https://lists.yoctoproject.org/listinfo/toaster
>>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster

-------------- next part --------------
A non-text attachment was scrubbed...
Name: one-build-inprogress.pdf
Type: application/pdf
Size: 103688 bytes
Desc: one-build-inprogress.pdf
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150903/c91f9c74/attachment-0001.pdf>