[Toaster] [review-request] bbarrosp/all-builds

[Barros Pena, Belen]

On 03/09/2015 15:23, "Smith, Elliot" <elliot.smith at intel.com> wrote:

>On 2 September 2015 at 13:48, Barros Pena, Belen
><belen.barros.pena at intel.com> wrote:
>
>This branch fixes some small presentation issues in the all builds page.
>
>a4f3389d77810f25eec548b01a3cd5698e934247
>toaster: Move project column
>
>
>
>
>This one causes the "Project" column to display on the projectbuilds
>page. This is because you've moved the place where the "Project" column
>is added to the context, which makes it *always* appear in the context.
>
>
>The changes in the branch we were discussing previously on the list
>(elliot/toaster/hide_builds-8236) mean that the _build_list_helper()
>method now knows where the page is being invoked from. This means we can
>change the context "properly" without having
> to rely on the hack (which you rightly fixed).
>
>
>I would suggest removing this commit and raising an issue to track the
>fact that the work needs to be done later, after we have improved
>_build_list_helper().

This sounds good to me.

Thanks!

Belén

>
>
>The rest of the branch looks fine. I will submit it once we've resolved
>what to do about the above.
>
>
>Elliot
> 
>
>
>aa165828cb77427f2594c7e2ee7ede6cb030a986
>toaster: replace ETA with % of tasks done
>
>82502db5bb70439350c582e740c63bd6cde51efd
>toaster: fix project names in latest builds
>
>c5eeb63334f3221a89ffdee44c1c5f5563c19bcd
>
>
>
>toaster: remove unnecessary white space
>
>Thanks!
>
>Belén
>
>
>
>
>
>
>
>
>
>--
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>-- 
>Elliot Smith
>Software Engineer
>Intel Open Source Technology Centre
>
>
>
>