[Toaster] [review-request][PATCH 0/3] Hide irrelevant builds

Brian Avery avery.brian at gmail.com
Thu Sep 3 22:54:18 PDT 2015


We probably need the equivalent of toaster-mut or toaster-next.
I was waiting for Michael W to get back to have that discussion but
I'm in favour.
-b

On Thu, Sep 3, 2015 at 1:09 AM, Smith, Elliot <elliot.smith at intel.com> wrote:
> On 3 September 2015 at 03:11, Brian Avery <avery.brian at gmail.com> wrote:
>>
>> Question:
>> How does this interact with the default_proj you did?  I couldn't
>> apply this patchset on top of that one and I upstreamed the
>> default_proj first.
>
>
> I have been struggling a bit with figuring out how to manage patches going
> upstream and clashing with each other.
>
> At the moment, I'm not using any kind of staging area for all the patches I
> know have gone upstream. Perhaps there is some branch where others are doing
> this, but I haven't been using it so far. Do we have such a thing?
>
> If not, can we agree on a branch which we use to stage all of the patches we
> submit to bitbake-devel, which we keep rebased on upstream master? I think
> this would help me in situations like this.
>
> Once we have it agreed, I am happy to attempt to bring it into line with
> what we think bitbake master should theoretically look like if all our
> submitted patches were included in it.
>
> It would then be the responsibility of a reviewer to add any patches they
> review to that branch, after they have been submitted to bitbake-devel. (If
> a patch gets rejected or altered after being submitted upstream, we would
> have to reconstruct our staging area to match upstream again.)
>
> I will test today to see whether there are any issues with the default
> project branch and the branch which hides "in progress" projects.
>
> Thanks.
> Elliot
>
>>
>>
>> When I did a quick apply by hand, I got errors when I tried to go look
>> at the "command line proj" page, but that may have been my mistake.
>>
>> We should probably make sure that this interacts ok with the
>> default_proj changes.
>> -b
>>
>> On Wed, Sep 2, 2015 at 9:22 AM, Barros Pena, Belen
>> <belen.barros.pena at intel.com> wrote:
>> >
>> >
>> > On 02/09/2015 17:04, "toaster-bounces at yoctoproject.org on behalf of
>> > Elliot
>> > Smith" <toaster-bounces at yoctoproject.org on behalf of
>> > elliot.smith at intel.com> wrote:
>> >
>> >>Hide "in progress" builds everywhere, and only show builds for
>> >>the currently-open project on the /project/X/builds page.
>> >>
>> >>Changes since 71b0568fa43285f0946fae93fb43cea5f3bbecec are in
>> >>git://git.yoctoproject.org/poky-contrib, elliot/toaster/hide_builds-8236
>>
>> >> >>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/hi
>> >>de_builds-8236
>> >
>> > The UI seems to be working correctly:
>> >
>> > * Builds in progress no longer show
>> > * Only the builds for the selected project are shown
>> >
>> > The latter means that this bug also fixes
>> >
>> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=8187
>> >
>> > Which was assigned to David Reyna, who had a patch out for review, I
>> > believe.
>> >
>> > Just bringing it up so you can decide which one should go in.
>> >
>> > Cheers
>> >
>> > Belén
>> >
>> >>
>> >>Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8236
>> >>
>> >>Alexandru DAMIAN (1):
>> >>  toaster: hide irrelevant builds in the project builds view
>> >>
>> >>Elliot Smith (2):
>> >>  toaster: Remove cast to date which causes errors during test
>> >>  toaster: Add tests for /project/X/builds page
>> >>
>> >> bitbake/lib/toaster/toastergui/tests.py | 91
>> >>++++++++++++++++++++++++++++++++-
>> >> bitbake/lib/toaster/toastergui/views.py | 59 +++++++++++++++------
>> >> bitbake/toaster-requirements.txt        |  1 +
>> >> 3 files changed, 134 insertions(+), 17 deletions(-)
>> >>
>> >>--
>> >>Elliot Smith
>> >>Software Engineer
>> >>Intel OTC
>> >>
>> >>---------------------------------------------------------------------
>> >>Intel Corporation (UK) Limited
>> >>Registered No. 1134945 (England)
>> >>Registered Office: Pipers Way, Swindon SN3 1RJ
>> >>VAT No: 860 2173 47
>> >>
>> >>This e-mail and any attachments may contain confidential material for
>> >>the sole use of the intended recipient(s). Any review or distribution
>> >>by others is strictly prohibited. If you are not the intended
>> >>recipient, please contact the sender and delete all copies.
>> >>
>> >>--
>> >>_______________________________________________
>> >>toaster mailing list
>> >>toaster at yoctoproject.org
>> >>https://lists.yoctoproject.org/listinfo/toaster
>> >
>> > --
>> > _______________________________________________
>> > toaster mailing list
>> > toaster at yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre


More information about the toaster mailing list