[Toaster] [review-request][PATCH 0/5] [v2] Hide irrelevant builds

Brian Avery avery.brian at gmail.com
Thu Sep 10 09:59:33 PDT 2015


yes. will do.
-b

On Thu, Sep 10, 2015 at 8:35 AM, Smith, Elliot <elliot.smith at intel.com> wrote:
> On 10 September 2015 at 12:11, Smith, Elliot <elliot.smith at intel.com> wrote:
>>
>> This is a bug on master, and isn't introduced by this patch.
>
>
> Here's the bug:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=8277
>
> Can we submit this patch to bitbake in the meantime?
>
> Thanks.
> Elliot
>
>>
>>
>> I just checked, and it also doesn't appear to have been caused by my
>> patches to how default project works.
>>
>> I will raise a separate issue to track it.
>>
>> Elliot
>>
>> On 9 September 2015 at 04:23, Brian Avery <avery.brian at gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> I found 1 more bug :(
>>>
>>> If you start toaster in analysis mode and navigate as follows:
>>> all projects -> Command line builds
>>> while a recipe is building (for instance core-image-minimal) you get an
>>> error:
>>>
>>> https://www.dropbox.com/s/gielruub058azug/Screenshot%202015-09-08%2020.19.03.png?dl=0
>>> if you wait until the build is done, you do not get an error.
>>>
>>> Error traceback:
>>> Environment:
>>>
>>>
>>> Request Method: GET
>>> Request URL: http://192.168.168.66:8000/toastergui/project/1/
>>>
>>> Django Version: 1.6
>>> Python Version: 2.7.6
>>> Installed Applications:
>>> ('django.contrib.auth',
>>>  'django.contrib.contenttypes',
>>>  'django.contrib.messages',
>>>  'django.contrib.sessions',
>>>  'django.contrib.admin',
>>>  'django.contrib.staticfiles',
>>>  'django.contrib.humanize',
>>>  'bldcollector',
>>>  'toastermain',
>>>  'south',
>>>  'toastergui',
>>>  'bldcontrol',
>>>  'orm')
>>> Installed Middleware:
>>> ('django.middleware.common.CommonMiddleware',
>>>  'django.contrib.sessions.middleware.SessionMiddleware',
>>>  'django.middleware.csrf.CsrfViewMiddleware',
>>>  'django.contrib.auth.middleware.AuthenticationMiddleware',
>>>  'django.contrib.messages.middleware.MessageMiddleware')
>>>
>>>
>>> Traceback:
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/core/handlers/base.py"
>>> in get_response
>>>   114.                     response = wrapped_callback(request,
>>> *callback_args, **callback_kwargs)
>>> File "/big/src/intel/myBugs/poky/bitbake/lib/toaster/toastergui/views.py"
>>> in returned_wrapper
>>>   150.                 context = view(request, *args, **kwargs)
>>> File "/big/src/intel/myBugs/poky/bitbake/lib/toaster/toastergui/views.py"
>>> in project
>>>   2273.             "builds" : _project_recent_build_list(prj),
>>> File "/big/src/intel/myBugs/poky/bitbake/lib/toaster/toastergui/views.py"
>>> in _project_recent_build_list
>>>   93.             "status": x.get_current_status(),
>>> File "/big/src/intel/myBugs/poky/bitbake/lib/toaster/orm/models.py" in
>>> get_current_status
>>>   354.         if self.outcome == Build.IN_PROGRESS and
>>> self.buildrequest.state != BuildRequest.REQ_INPROGRESS:
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/fields/related.py"
>>> in __get__
>>>   197.                     rel_obj =
>>> self.get_queryset(instance=instance).get(**params)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/query.py"
>>> in get
>>>   301.         num = len(clone)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/query.py"
>>> in __len__
>>>   77.         self._fetch_all()
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/query.py"
>>> in _fetch_all
>>>   854.             self._result_cache = list(self.iterator())
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/query.py"
>>> in iterator
>>>   220.         for row in compiler.results_iter():
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py"
>>> in results_iter
>>>   710.         for rows in self.execute_sql(MULTI):
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py"
>>> in execute_sql
>>>   781.         cursor.execute(sql, params)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/backends/util.py"
>>> in execute
>>>   69.             return super(CursorDebugWrapper, self).execute(sql,
>>> params)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/backends/util.py"
>>> in execute
>>>   53.                 return self.cursor.execute(sql, params)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/utils.py"
>>> in __exit__
>>>   99.                 six.reraise(dj_exc_type, dj_exc_value, traceback)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/backends/util.py"
>>> in execute
>>>   53.                 return self.cursor.execute(sql, params)
>>> File
>>> "/big/src/intel/yocto-builds/TOASTER/myBugs/t-myBugs/local/lib/python2.7/site-packages/django/db/backends/sqlite3/base.py"
>>> in execute
>>>   450.         return Database.Cursor.execute(self, query, params)
>>>
>>> Exception Type: OperationalError at /toastergui/project/1/
>>> Exception Value: no such table: bldcontrol_buildrequest
>>>
>>> -b
>>>
>>> On Fri, Sep 4, 2015 at 3:55 AM, Barros Pena, Belen
>>> <belen.barros.pena at intel.com> wrote:
>>> >
>>> >
>>> > On 04/09/2015 10:37, "toaster-bounces at yoctoproject.org on behalf of
>>> > Elliot
>>> > Smith" <toaster-bounces at yoctoproject.org on behalf of
>>> > elliot.smith at intel.com> wrote:
>>> >
>>> >>Hide "in progress" builds everywhere, and only show builds for
>>> >>the currently-open project on the /project/X/builds page.
>>> >>
>>> >>Changes since bc6a1a23e3d1af3861288a7abdbc9d5010470204 are in
>>> >>git://git.yoctoproject.org/poky-contrib,
>>> >> elliot/toaster/hide_builds-8236
>>>
>>> >> >>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/hi
>>> >>de_builds-8236
>>> >
>>> > UI looks good to me. Thanks!
>>> >
>>> > Belén
>>> >
>>> >>
>>> >>Related bugs:
>>> >>https://bugzilla.yoctoproject.org/show_bug.cgi?id=8236
>>> >>https://bugzilla.yoctoproject.org/show_bug.cgi?id=8187
>>> >>
>>> >>Alexandru DAMIAN (1):
>>> >>  toaster: hide irrelevant builds in the project builds view
>>> >>
>>> >>Elliot Smith (4):
>>> >>  toaster: Add tests for /project/X/builds page
>>> >>  toaster: Show correct builds count on project pages
>>> >>  toaster: Fix date range pickers on the project builds page
>>> >>  toaster: Simplify redirects when build page parameters are missing
>>> >>
>>> >> bitbake/lib/toaster/toastergui/static/js/base.js   |   4 +-
>>> >> .../toastergui/templates/projectbuilds.html        |   4 +-
>>> >> bitbake/lib/toaster/toastergui/tests.py            |  91
>>> >>++++++++++++++++-
>>> >> bitbake/lib/toaster/toastergui/views.py            | 108
>>> >>+++++++++++++++------
>>> >> bitbake/toaster-requirements.txt                   |   1 +
>>> >> 5 files changed, 169 insertions(+), 39 deletions(-)
>>> >>
>>> >>--
>>> >>Elliot Smith
>>> >>Software Engineer
>>> >>Intel OTC
>>> >>
>>> >>---------------------------------------------------------------------
>>> >>Intel Corporation (UK) Limited
>>> >>Registered No. 1134945 (England)
>>> >>Registered Office: Pipers Way, Swindon SN3 1RJ
>>> >>VAT No: 860 2173 47
>>> >>
>>> >>This e-mail and any attachments may contain confidential material for
>>> >>the sole use of the intended recipient(s). Any review or distribution
>>> >>by others is strictly prohibited. If you are not the intended
>>> >>recipient, please contact the sender and delete all copies.
>>> >>
>>> >>--
>>> >>_______________________________________________
>>> >>toaster mailing list
>>> >>toaster at yoctoproject.org
>>> >>https://lists.yoctoproject.org/listinfo/toaster
>>> >
>>> > --
>>> > _______________________________________________
>>> > toaster mailing list
>>> > toaster at yoctoproject.org
>>> > https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>> --
>> Elliot Smith
>> Software Engineer
>> Intel Open Source Technology Centre
>
>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre


More information about the toaster mailing list