[Toaster] [review-request] [PATCH] toaster: remove time from builds in progress

[Smith, Elliot]

Looks good to me, submitted to bitbake-devel.

Elliot

On 14 September 2015 at 17:45, Belen Barros Pena <
belen.barros.pena at linux.intel.com> wrote:

> From: Belen Barros Pena <belen.barros.pena at intel.com>
>
> In the 'latest builds' section of the all builds page,
> completed builds show the time they completed at. Builds
> in progress should not display such time, since they
> haven't completed yet.
>
> This patch removes the time information that was showing
> for builds in progress, whatever that time actually was.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena at intel.com>
> ---
>  bitbake/lib/toaster/toastergui/templates/mrb_section.html | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/mrb_section.html
> b/bitbake/lib/toaster/toastergui/templates/mrb_section.html
> index 396fb8e..c5e9c87 100644
> --- a/bitbake/lib/toaster/toastergui/templates/mrb_section.html
> +++ b/bitbake/lib/toaster/toastergui/templates/mrb_section.html
> @@ -38,6 +38,7 @@
>                  </a>
>      {% endif %}
>              </div>
> +    {% if build.outcome == build.SUCCEEDED or build.outcome ==
> build.FAILED %}
>              <div class="span2 lead">
>                  {% if build.completed_on|format_build_date  %}
>                      {{ build.completed_on|date:'d/m/y H:i' }}
> @@ -45,6 +46,7 @@
>                      {{ build.completed_on|date:'H:i' }}
>                  {% endif %}
>              </div>
> +    {% endif %}
>      {%if build.outcome == build.SUCCEEDED or build.outcome ==
> build.FAILED %}
>              <div class="span2 lead">
>        {% if  build.errors.count %}
> @@ -79,7 +81,7 @@
>              </div>
>      {%endif%}
>      {%if build.outcome == build.IN_PROGRESS %}
> -            <div class="span4">
> +            <div class="span4 offset1">
>                  <div class="progress" style="margin-top:5px;"
> data-toggle="tooltip" title="{{build.completeper}}% of tasks complete">
>                      <div style="width: {{build.completeper}}%;"
> class="bar"></div>
>                  </div>
> --
> 2.3.2 (Apple Git-55)
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150921/762cd062/attachment.html>