[Toaster] [review-request][PATCH] toaster: Add fake entry to Target_File for filesystem root

[Smith, Elliot]

On 22 September 2015 at 09:03, Ed Bartosh <ed.bartosh at linux.intel.com>
wrote:

> On Mon, Sep 21, 2015 at 06:49:22PM +0100, Elliot Smith wrote:
> > The files-in-image.txt file is produced by bitbake after an
> > image is created, listing all the files in the image.
> > However, this list doesn't include the root directory ('/').
> >
> Did you try to look what caused this change? Bitbake used to include
> root dir into this file previously, right?
>

I'm not sure if it ever did include this file. I had a brief look at how
buildhistory_analysis.py does its work (git diffs if I read it correctly),
but didn't dig right into it.


> > buildinfohelper.py then tries to construct the filesystem
> > tree from this file, assuming that every directory apart from
> > the root directory (which is special-cased) can be assigned
> > a parent. But because the root directory isn't listed in
> > files-in-image.txt, an object for the root directory is never
> > created.
> >
> > The direct subdirectories of the root ('./bin', './usr' etc.)
> > then can't be assigned a parent directory, as the object
> > representing the root directory doesn't exist. This
> > results in a Target_File lookup error and causes the
> > directory listing page to fail.
> >
> > Fix this by creating a fake entry for the root directory
> > in the Target_File table, so that the direct subdirectories
> > of / can be assigned a parent. Note that it doesn't matter
> > that the root is faked, as its properties are never shown
> > in the directory structure tree.
> >
> This looks like a workaround to me. It should be fixed in bitbake code
> if it's possible.
>

 I discussed this with Brian, and the decision was that a work-around was
sufficient for now. (See the options I suggested in
https://bugzilla.yoctoproject.org/show_bug.cgi?id=8280#c9.)

I can investigate this some more and/or raise a bug, if we think that's
worthwhile.

Elliot
-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150922/898a1924/attachment.html>