[Toaster] [PATCH v8 44/45] toasterui: update build in internal state
Ed Bartosh
ed.bartosh at linux.intel.com
Mon Apr 4 00:27:15 PDT 2016
buildinfohelper stores current Build object in its internal
state. Any changes to Build object will be lost if internal
state is not updated as current buildinfohelper code
saves Build object from internal state when build is
completed.
This bug causes incorrect build state when build is cancelled.
Updating internal state should fix it.
Note, that this commit updates internal state after status of
the build is changed to Build.CANCELLED. There are several other
places in the code where Build object is updated without updating
internal state. They should be carefully analyzed and fixed.
Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
---
bitbake/lib/bb/ui/buildinfohelper.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/bitbake/lib/bb/ui/buildinfohelper.py b/bitbake/lib/bb/ui/buildinfohelper.py
index 3dd4edd..cf2c845 100644
--- a/bitbake/lib/bb/ui/buildinfohelper.py
+++ b/bitbake/lib/bb/ui/buildinfohelper.py
@@ -1413,6 +1413,7 @@ class BuildInfoHelper(object):
logger.info("Build cancelled")
br.build.outcome = Build.CANCELLED
br.build.save()
+ self.internal_state['build'] = br.build
errorcode = 0
if errorcode == 0:
--
2.1.4
More information about the toaster
mailing list