[Toaster] [toaster] [review-request] 9154: fixes for customimage details 'no package found'

[Smith, Elliot]

Sorry I've only just got to this, Dave.

The code generally looks fine.

My only question is why you've added an element with a different id to hold
the alternative no results area. Is there any reason it can't have the same
id="no-package-results" as the standard area?

Similarly, the input element could have the
name "#new-search-input-"+ctx.tableName so that its content is reset by the
existing code in table.js.

This could (I think) remove the need for any changes to table.js.

Elliot

On 16 March 2016 at 17:29, Dave Lerner <dave.lerner at windriver.com> wrote:

>
> Branch: toaster-next, master
> Defect: 9154
> Summary: Fixes when search for customimage packages has no results.
>
> jshint: done
> html5 validation: done
>
> Test cases and expected results
> -------------------------------
> Setup
> -----
> Build a custom image
>
> Static Text
> -----------
> Select the custom image and enter an unknown package like "xxxxx".
>     Verify that the static text matches the spec with caveats below.
>     1.  The spec shows a different header for both the no results
>         and the results page.  The spec was interpretted as being
> out-of-date
>         with current implemenation, and the well "About package..." was
>         assumed to be the current implementation replacment since it shows
>         the packages included and other data.
>     2:  The spec "search query" was assumed to be a place holder in
>         the design doc for a string that was the last unsucessful 'search
>         query'.
>     Verify that the text field has the unmatched string xxxxx
>
> All buttons - x, search, search all packages, search recipes
> -----------------------------------------------------------------
> X button:
> click the x icon
>     Verify that the text input is cleared.
>     Verify that the X icon is cleared.
>     Verify "Search Add | Remove packages" placeholder in text field.
>
> Search:
> enter openssl
> click search
>     Verify back to customised screen with packages matching 'openssl'
>
> On customise image main page, append abc to openssl and click search
>     Verify back to the No packages found screen
> On NO packages found page, change text from opensslabc to opensslxyz
> click search
>     Verify still on No Packages screen
>
> Search all packages:
> On the same 'opensslxyz' No packages found page,
> click Search all packages
>     Verify back to unfiltered customised image page
>
> Recipes:
> Enter helloworld, click search
> On 'No packages found' page, click the hyperlink "searching the list of
> recipes"
>     Verify that the software recipes page appears.
>
>


-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160406/2a1cfe44/attachment.html>