[Toaster] [review-request]Fixed old UI tests

[Brian Avery]

Hi,

A couple of comments:
1) I strongly agree with Elliot that the time.sleep should go away.
Since we are migrating alot of tests to different machines/places,
assuming that we know the machine characteristics is certainly going
to go poorly. The wait_until API makes more sense.

2) Selenium tests in a QA framework for tests that require actual
builds make sense.  For anything else that can be done with fixture
data, it would be much much better to extend elliot's Django tests in
bitbake/lib/toaster/tests/browser.  These are fast to run since they
don't need actual bitbake interactions.  This means that the devs
can/will run them and will also be able to keep them up to date.  This
way, the tests can perform a CI use for the devs and, since QA can
also wrap these tests, it would let QA use them too. If we use the
tests as is, it seems very very likely that they will become stale
very soon, especially considering the theme changes that are ongoing
at the moment.  I've added the bitbake/lib/toaster/tests/browser tests
to the Contribute to Toaster page so that people remember to run/keep
them up to date!

3) For merging into the bitbake/lib/toaster/tests/browser tests, these
need some work for readability/maintainability.


-bavery
an Intel employee

On Tue, Apr 12, 2016 at 8:15 AM, Mihail, StanciuX
<stanciux.mihail at intel.com> wrote:
> Hello,
>
>
>
> I’ve resolved the conflicts here:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=mstanciu/merged_ui_tests
>
>
>
> They should rebase over master with no issues.
>
>
>
> Please let us know if more changes are needed.
>
>
>
> Regards,
>
> Mihai
>
>
>
> From: Smith, Elliot [mailto:elliot.smith at intel.com]
> Sent: Monday, April 11, 2016 7:43 PM
> To: Mihail, StanciuX
> Cc: toaster at yoctoproject.org; Hangan, ValentinX; Roman, Alexandru CostinX
> Subject: Re: [Toaster] [review-request]Fixed old UI tests
>
>
>
> Does this branch supersede vhangan/automated_toaster_ui_tests ?
>
>
>
> I tried to cherry pick the commits off vhangan/automated_toaster_ui_tests
> then the commits off vhangan/toaster_tests_fixed, but they conflict with
> each other.
>
>
>
> Thanks.
>
> Elliot
>
>
>
> On 8 April 2016 at 15:15, Mihail, StanciuX <stanciux.mihail at intel.com>
> wrote:
>
> Hello,
>
>
>
> We’ve fixed the older UI tests to work with the latest changes to IDs.
>
> You can find the code here:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=vhangan/toaster_tests_fixed
>
>
>
> Please let us know if anything needs updating.
>
>
>
> Regards,
>
> Mihai
>
>
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
> --
>
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>