[Toaster] [PATCH 0/4] Validate custom image names correctly

[Smith, Elliot]

Thanks for the review, Dave. I'll have another look at this once the
Bootstrap 3 work is done.

Elliot

On 13 April 2016 at 21:57, Lerner, Dave M (Wind River) <
dave.lerner at windriver.com> wrote:

> Hi Elliot,
>
> I cannot reproduce the original symptom in your steps, outlined at
> https://lists.yoctoproject.org/pipermail/toaster/2016-April/004425.html.
> Specifically step 6 passes without your patches. Or using Belen's steps in
> the defect:
> ======
>   1. Create a Toaster project.
>   2. Create a custom image
>   3. Create a second Toaster project
>   4. Create a custom image and try to give it the same name you used for
> the custom
>      image you created in step 2
>   Toaster will complain that a custom image with that name already exists.
> ======
> The complaint is gone, this symptom no longer occurs without your patch
> 1/4.
>
> Neither her steps nor yours in the 0/4 RR email state that the custom
> image must be built, just created, so my baseline steps don't build the
> custom image.
>
> Patch 2/4 addresses a different issue, but I don't know how to test the
> baseline fault nor test the fix.
>
> Since patch 1/4 isn't necessary with respect to the defect, shouldn't it
> be dropped?You could provide a defect with or without a test for the fix in
> patch 2/4.
>
> Dave
> > -----Original Message-----
> > From: toaster-bounces at yoctoproject.org [mailto:
> toaster-bounces at yoctoproject.org] On
> > Behalf Of Elliot Smith
> > Sent: Monday, April 11, 2016 6:27 AM
> > To: toaster at yoctoproject.org
> > Subject: [Toaster] [PATCH 0/4] Validate custom image names correctly
> >
> > We currently validate the name of a new custom image across all projects.
> > This means you can't use the same custom image name in multiple projects.
> >
> > Modify the code to do validation correctly, and add UI tests to verify.
> >
> > To test:
> >
> > 1. Create a project.
> > 2. Create a custom image with name 'goo' in this project; it should work.
> > 3. Try to create another custom image called 'goo' in this project; it
> should fail.
> > 4. Try to create a custom image called 'core-image-minimal' in this
> project; it should
> > fail.
> > 5. Create another project.
> > 6. Create a custom image called 'goo' in the second project; it should
> work.
> >
> > The following changes since commit
> 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2:
> >
> >   toaster: fixes for customimage package not found (2016-04-08 09:38:50
> +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.yoctoproject.org/poky-contrib
> elliot/toaster/recipe_name_validation-9209
> >   http://git.yoctoproject.org/cgit.cgi/poky-
> > contrib/log/?h=elliot/toaster/recipe_name_validation-9209
> >
> > Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209
> >
> > Elliot Smith (4):
> >   toaster: only prevent duplicate custom image names within a project
> >   toaster: prevent exception when Project.release is null
> >   toaster-tests: add tests for new custom image page
> >   toaster-tests: make helper click on input before entering text
> >
> >  bitbake/lib/toaster/orm/models.py                  |  16 ++-
> >  .../lib/toaster/tests/browser/selenium_helpers.py  |   6 +-
> >  .../tests/browser/test_new_custom_image_page.py    | 160
> +++++++++++++++++++++
> >  .../toastergui/static/js/newcustomimage_modal.js   |   8 +-
> >  bitbake/lib/toaster/toastergui/views.py            |  33 +++--
> >  5 files changed, 200 insertions(+), 23 deletions(-)
> >  create mode 100644
> bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py
> >
> > --
> > 1.9.3
> >
> > ---------------------------------------------------------------------
> > Intel Corporation (UK) Limited
> > Registered No. 1134945 (England)
> > Registered Office: Pipers Way, Swindon SN3 1RJ
> > VAT No: 860 2173 47
> >
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> >
> > --
> > _______________________________________________
> > toaster mailing list
> > toaster at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160414/de425420/attachment.html>