[Toaster] Review for work on 9913

[sujith h]

Hi Belen,

On Wed, Aug 17, 2016 at 11:25 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

>
>
> On 17/08/2016 09:56, "toaster-bounces at yoctoproject.org on behalf of sujith
> h" <toaster-bounces at yoctoproject.org on behalf of sujith.h at gmail.com>
> wrote:
>
> >Hi,
> >
> >
> >I am submitting my branch
> >http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
> log/?h=sujith/switc
> >h-imported-dirs-and-git-repos-9913
> ><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
> log/?h=sujith/swit
> >ch-imported-dirs-and-git-repos-9913> for review. Yesterday, Michael did
> >the code review. Now the UI review has to happen.
>
> Hi Sujith,
>
> Thanks for the branch. This essentially works: I can edit an imported
> layer information.
>
> There are some issues with the layout of the page, but we can easily fix
> those after merging the patches.
>
> There are also 2 small problems with the "edit" form behaviour:
>
> 1. The "edit" form is supposed to replace the layer source code
> information, so when I click the "edit" button and the form comes up, the
> "Path to the layer directory" information at the top of the page (or the
> git repository information) should be hidden, and shown back again when
> you click the "save changes" button. You can see the behaviour at
>
> http://www.yoctoproject.org/toaster/b3/layer-details-dir.html


I have updated my branch. I have verified when "edit" button is clicked the
form comes up and
the "Path to the layer directory" information at the top of the page is
hidden. And when user clicks
the cancel button in the form ( that is no changes are made ), the "Path to
the layer directory" is
shown back.


>
>
> 2. For some reason, it takes quite a long time for the form to react when
> you click the 'save changes' button. I am not sure if there is something
> we can do about this: maybe Michael has some suggestions.
>
> In any case, since we are under a bit of pressure to get the functionality
> merged before the m3 cut off, I think we should submit this upstream, and
> take care of these little problems later during m4.
>
> Thanks!
>
> Belén
>

Thanks,
Sujith H

-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160818/8cdae4fa/attachment.html>